Re: CVS commit: pkgsrc

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Wed, Jun 08, 2022 at 07:00:13PM +0000, Chuck Cranor wrote:
> Module Name:  pkgsrc
> Committed By: chuck
> Date:         Wed Jun  8 19:00:13 UTC 2022
> 
> Modified Files:
>       pkgsrc/doc: CHANGES-2022
>       pkgsrc/fonts/t1lib: Makefile distinfo
> Added Files:
>       pkgsrc/fonts/t1lib/patches: patch-lib_type1_objects.h
>           patch-lib_type1_regions.c
> 
> Log Message:
> work around clang compiler issue and malloc overflow in t1lib
> 
> there are two bugs in fonts/t1lib that cause math/grace to crash on OSX:
> 
> [1] compiler bug in some versions of clang when compiling with "-O2" ...
>     this appears to have been fixed somewhere between clang-11 and clang-12.
>     it works ok with "-O1" and it doesn't impact my NetBSD system (which
>     has gcc instead of clang).   resolve by using memcpy() in LONGCOPY()
>     macro rather than using custom code that triggers the clang issue.
>     see: https://mail-index.netbsd.org/tech-pkg/2022/06/08/msg026367.html

This code smells like a violation of aliasing rules. Is LONGCOPY ever
used with overlapping memory? Because in that case the change is not
correct.

Joerg