CVS commit: pkgsrc/security/sudo

["Takahiro Kambe" <taca%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   taca
Date:           Sun Aug 13 14:14:37 UTC 2023

Modified Files:
        pkgsrc/security/sudo: Makefile distinfo
        pkgsrc/security/sudo/patches: patch-configure

Log Message:
security/sudo: update to 1.9.14p3

What's new in Sudo 1.9.14p3

 * Fixed a crash with Python 3.12 when the sudo Python python is
   unloaded.  This only affects "make check" for the Python plugin.
 * Adapted the sudo Python plugin test output to match Python 3.12.

What's new in Sudo 1.9.14p2

 * Fixed a crash on Linux systems introduced in version 1.9.14 when
   running a command with a NULL argv[0] if "log_subcmds" or
   "intercept" is enabled in sudoers.
 * Fixed a problem with "stair-stepped" output when piping or
   redirecting the output of a sudo command that takes user input.
 * Fixed a bug introduced in sudo 1.9.14 that affects matching
   sudoers rules containing a Runas_Spec with an empty Runas user.
   These rules should only match when sudo's -g option is used but
   were matching even without the -g option.  GitHub issue #290.

What's new in Sudo 1.9.14p1

 * Fixed an invalid free bug in sudo_logsrvd that was introduced
   in version 1.9.14 which could cause sudo_logsrvd to crash.
 * The sudoers plugin no longer tries to send the terminal name
   to the log server when no terminal is present.  This bug was
   introduced in version 1.9.14.

What's new in Sudo 1.9.14

 * Fixed a bug where if the "intercept" or "log_subcmds" sudoers
   option was enabled and a sub-command was run where the first
   entry of the argument vector didn't match the command being run.
   This resulted in commands like "sudo su -" being killed due to
   the mismatch.  Bug #1050.
 * The sudoers plugin now canonicalizes command path names before
   matching (where possible).  This fixes a bug where sudo could
   execute the wrong path if there are multiple symbolic links with
   the same target and the same base name in sudoers that a user is
   allowed to run.  GitHub issue #228.
 * Improved command matching when a chroot is specified in sudoers.
   The sudoers plugin will now change the root directory id needed
   before performing command matching.  Previously, the root directory
   was simply prepended to the path that was being processed.
 * When NETGROUP_BASE is set in the ldap.conf file, sudo will now
   perform its own netgroup lookups of the host name instead of
   using the system innetgr(3) function.  This guarantees that user
   and host netgroup lookups are performed using  the same LDAP
   server (or servers).
 * Fixed a bug introduced in sudo 1.9.13 that resulted in a missing
   " ; " separator between environment variables and the command
   in log entries.
 * The visudo utility now displays a warning when it ignores a file
   in an include dir such as /etc/sudoers.d.
 * When running a command in a pseudo-terminal, sudo will initialize
   the terminal settings even if it is the background process.
   Previously, sudo only initialized the pseudo-terminal when running
   in the foreground.  This fixes an issue where a program that
   checks the window size would read the wrong value when sudo was
   running in the background.
 * Fixed a bug where only the first two digits of the TSID field
   being was logged.  Bug #1046.
 * The "use_pty" sudoers option is now enabled by default.  To
   restore the historic behavior where a command is run in the
   user's terminal, add "Defaults !use_pty" to the sudoers file.
   GitHub issue #258.
 * Sudo's "-b" option now works when the command is run in a
   pseudo-terminal.
 * When disabling core dumps, sudo now only modifies the soft limit
   and leaves the hard limit as-is.  This avoids problems on Linux
   when sudo does not have CAP_SYS_RESOURCE, which may be the case
   when run inside a container.  GitHub issue #42.
 * Sudo configuration file paths have been converted to colon-separated
   lists of paths.  This makes it possible to have configuration
   files on a read-only file system while still allowing for local
   modifications in a different (writable) directory.  The new
   --enable-adminconf configure option can be used to specify a
   directory that is searched for configuration files in preference
   to the sysconfdir (which is usually /etc).
 * The "intercept_verify" sudoers option is now only applied when
   the "intercept" option is set in sudoers.  Previously, it was
   also applied when "log_subcmds" was enabled.
 * The NETGROUP_QUERY ldap.conf parameter can now be disabled for
   LDAP servers that do not support querying the nisNetgroup object
   by its nisNetgroupTriple attribute, while still allowing sudo to
   query the LDAP server directly to determine netgroup membership.
 * Fixed a long-standing bug where a sudoers rule without an explicit
   runas list allowed the user to run a command as root and any
   group instead of just one of the groups that root is a member
   of.  For example, a rule such as "myuser ALL = ALL" would permit
   "sudo -u root -g othergroup" even if root did not belong to
   "othergroup".
 * Fixed a bug where a sudoers rule with an explicit runas list
   allowed a user to run sudo commands as themselves.  For example,
   a rule such as "myuser ALL = (root) ALL", "myuser" should only
   allow commands to be run as root (optionally using one of root's
   groups).  However, the rule also allowed the user to run
   "sudo -u myuser -g myuser command".
 * Fixed a bug that prevented the user from specifying a group on
   the command line via "sudo -g" if the rule's Runas_Spec contained
   a Runas_Alias.
 * Sudo now requires a C compiler that conforms to ISO C99 or higher
   to build.


To generate a diff of this commit:
cvs rdiff -u -r1.197 -r1.198 pkgsrc/security/sudo/Makefile
cvs rdiff -u -r1.129 -r1.130 pkgsrc/security/sudo/distinfo
cvs rdiff -u -r1.10 -r1.11 pkgsrc/security/sudo/patches/patch-configure

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/security/sudo/Makefile
diff -u pkgsrc/security/sudo/Makefile:1.197 pkgsrc/security/sudo/Makefile:1.198
--- pkgsrc/security/sudo/Makefile:1.197 Fri Mar 17 14:03:47 2023
+++ pkgsrc/security/sudo/Makefile       Sun Aug 13 14:14:37 2023
@@ -1,6 +1,6 @@
-# $NetBSD: Makefile,v 1.197 2023/03/17 14:03:47 taca Exp $
+# $NetBSD: Makefile,v 1.198 2023/08/13 14:14:37 taca Exp $
 
-DISTNAME=      sudo-1.9.13p3
+DISTNAME=      sudo-1.9.14p3
 CATEGORIES=    security
 MASTER_SITES=  https://www.sudo.ws/dist/
 MASTER_SITES+= ftp://ftp.sudo.ws/pub/sudo/
@@ -44,7 +44,7 @@ PLIST.noexec=         yes
 .if ${OPSYS} == "NetBSD" && ${OPSYS_VERSION} > 070000
 CFLAGS+=       -D_OPENBSD_SOURCE=1
 .endif
-.if !empty(MACHINE_PLATFORM:MNetBSD-[5-6].*-*)
+.if ${MACHINE_PLATFORM:MNetBSD-[5-6].*-*}
 CFLAGS+=       -D_INCOMPLETE_XOPEN_C063=1
 .endif
 

Index: pkgsrc/security/sudo/distinfo
diff -u pkgsrc/security/sudo/distinfo:1.129 pkgsrc/security/sudo/distinfo:1.130
--- pkgsrc/security/sudo/distinfo:1.129 Fri Mar 17 14:03:47 2023
+++ pkgsrc/security/sudo/distinfo       Sun Aug 13 14:14:37 2023
@@ -1,10 +1,10 @@
-$NetBSD: distinfo,v 1.129 2023/03/17 14:03:47 taca Exp $
+$NetBSD: distinfo,v 1.130 2023/08/13 14:14:37 taca Exp $
 
-BLAKE2s (sudo-1.9.13p3.tar.gz) = 425df1e87fd0e6f377fe1a2a67cc28fa532c5c70fdb3b375207cbad0cb7bec23
-SHA512 (sudo-1.9.13p3.tar.gz) = c0c5cd0c6308868afdad2ecf55b86fdcf1f49889b30831c9db3bc56a63dc3a07686c285c20b2500494b2a76653e2ec69196abdc583312609a5db1c81a6e4e737
-Size (sudo-1.9.13p3.tar.gz) = 5100355 bytes
+BLAKE2s (sudo-1.9.14p3.tar.gz) = ede93724daf64c1aa294ae85a3228b4d53863b1e7d61a849ada87e1ee7c26eb0
+SHA512 (sudo-1.9.14p3.tar.gz) = d4af836e3316c35d8b81a2c869ca199e8f2d5cb26dbd98b8ad031f29be62b154452afdf5a506ddabad21b80e5988a49f1f7c8f1ec44718ffcbd7e89ccbdef612
+Size (sudo-1.9.14p3.tar.gz) = 5232320 bytes
 SHA1 (patch-Makefile.in) = 1a83c55d27829013e2e23073046c5c39b020fafe
-SHA1 (patch-configure) = 0f73f860ae4fd9a0031aa8b0c22a93df776e7ad6
+SHA1 (patch-configure) = 824095fe7be5f8503434581a07e947c94552b0f7
 SHA1 (patch-examples_Makefile.in) = a20967ecd88eb5e4a8b47e6a3b80bc18be713409
 SHA1 (patch-lib_logsrv_Makefile.in) = 301c317c806edeee8ce7b44a5431cd38defb3a54
 SHA1 (patch-lib_protobuf-c_Makefile.in) = 122e432fb0da36b998778a1b71130f0c3785f575

Index: pkgsrc/security/sudo/patches/patch-configure
diff -u pkgsrc/security/sudo/patches/patch-configure:1.10 pkgsrc/security/sudo/patches/patch-configure:1.11
--- pkgsrc/security/sudo/patches/patch-configure:1.10   Mon Feb 20 13:36:42 2023
+++ pkgsrc/security/sudo/patches/patch-configure        Sun Aug 13 14:14:37 2023
@@ -1,4 +1,4 @@
-$NetBSD: patch-configure,v 1.10 2023/02/20 13:36:42 taca Exp $
+$NetBSD: patch-configure,v 1.11 2023/08/13 14:14:37 taca Exp $
 
 * Add "--with-nbsdops" option, NetBSD standard options.
 * When specified "--with-kerb5" option, test existence of several functions
@@ -6,9 +6,9 @@ $NetBSD: patch-configure,v 1.10 2023/02/
   functions (HAVE_KRB5_*).
 * Remove setting sysconfdir to "/etc".
 
---- configure.orig     2023-02-16 18:43:30.000000000 +0000
+--- configure.orig     2023-07-24 20:25:13.000000000 +0000
 +++ configure
-@@ -935,6 +935,7 @@ with_incpath
+@@ -937,6 +937,7 @@ with_incpath
  with_libpath
  with_libraries
  with_csops
@@ -16,7 +16,7 @@ $NetBSD: patch-configure,v 1.10 2023/02/
  with_passwd
  with_skey
  with_opie
-@@ -1673,7 +1674,7 @@ Fine tuning of the installation director
+@@ -1676,7 +1677,7 @@ Fine tuning of the installation director
    --bindir=DIR            user executables [EPREFIX/bin]
    --sbindir=DIR           system admin executables [EPREFIX/sbin]
    --libexecdir=DIR        program executables [EPREFIX/libexec]
@@ -25,7 +25,7 @@ $NetBSD: patch-configure,v 1.10 2023/02/
    --sharedstatedir=DIR    modifiable architecture-independent data [PREFIX/com]
    --localstatedir=DIR     modifiable single-machine data [PREFIX/var]
    --runstatedir=DIR       modifiable per-process data [LOCALSTATEDIR/run]
-@@ -1802,6 +1803,7 @@ Optional Packages:
+@@ -1808,6 +1809,7 @@ Optional Packages:
    --with-libpath          additional places to look for libraries
    --with-libraries        additional libraries to link with
    --with-csops            add CSOps standard options
@@ -33,7 +33,7 @@ $NetBSD: patch-configure,v 1.10 2023/02/
    --without-passwd        don't use passwd/shadow file for authentication
    --with-skey[=DIR]       enable S/Key support
    --with-opie[=DIR]       enable OPIE support
-@@ -5290,6 +5292,23 @@ fi
+@@ -5329,6 +5331,23 @@ fi
  
  
  
@@ -57,7 +57,7 @@ $NetBSD: patch-configure,v 1.10 2023/02/
  # Check whether --with-passwd was given.
  if test ${with_passwd+y}
  then :
-@@ -18196,7 +18215,7 @@ fi
+@@ -18263,7 +18282,7 @@ fi
                : ${mansectform='4'}
                : ${mansectmisc='5'}
                ;;
@@ -66,7 +66,7 @@ $NetBSD: patch-configure,v 1.10 2023/02/
                shadow_funcs="getspnam"
                test -z "$with_pam" && AUTH_EXCL_DEF="PAM"
                # Check for SECCOMP_MODE_FILTER in linux/seccomp.h
-@@ -29486,6 +29505,8 @@ rm -f core conftest.err conftest.$ac_obj
+@@ -29669,6 +29688,8 @@ rm -f core conftest.err conftest.$ac_obj
       ;;
  esac
  fi
@@ -75,11 +75,11 @@ $NetBSD: patch-configure,v 1.10 2023/02/
      _LIBS="$LIBS"
      LIBS="${LIBS} ${SUDOERS_LIBS}"
      ac_fn_c_check_func "$LINENO" "krb5_verify_user" "ac_cv_func_krb5_verify_user"
-@@ -35492,7 +35513,6 @@ test "$docdir" = '${datarootdir}/doc/${P
- test "$localedir" = '${datarootdir}/locale' && localedir='$(datarootdir)/locale'
- test "$localstatedir" = '${prefix}/var' && localstatedir='$(prefix)/var'
- test "$runstatedir" = '${localstatedir}/run' && runstatedir='$(localstatedir)/run'
--test "$sysconfdir" = '${prefix}/etc' && sysconfdir='/etc'
+@@ -35634,7 +35655,6 @@ test X"$localedir" = X'${datarootdir}/lo
+ test X"$localstatedir" = X'${prefix}/var' && localstatedir='$(prefix)/var'
+ test X"$runstatedir" = X'${localstatedir}/run' && runstatedir='$(localstatedir)/run'
+ test X"$adminconfdir" = X'${prefix}/etc' && adminconfdir='$(prefix)/etc'
+-test X"$sysconfdir" = X'${prefix}/etc' && sysconfdir='/etc'
  
- if test X"$INIT_SCRIPT" != X""
- then :
+ # The configuration file search path is to check adminconfdir first and
+ # fall back to sysconfdir.  This can support systems with read-only