Re: CVS commit: pkgsrc/devel/libgit2

[pin <voidpin%protonmail.com@localhost>]

Sent with Proton Mail secure email.

------- Original Message -------
On Thursday, October 19th, 2023 at 1:15 PM, Adam <adam%netbsd.org@localhost> wrote:


> > > > cargo-c is at the latest version but it looks like it ships
> > > > with a version of the libgit2-sys crate that is too old.
> > > > So we might need to patch cargo-c to use a newer crate.
> > > 
> > > Yes, I know that this will break a couple of rust crates - pin@ said
> > > he'd take care of it in the next days. Thanks, pin!
> > 
> > It is not acceptable to leave this broken for too long.
> > The dependency chain cargo-c -> libimagequant -> gd
> > breaks many things. So I mended the package temporarily.
> > 
> > Unfortunately, regenerating cargo-depends.mk now requires manual
> > undocumented hacks. But it should be back to normal again when the
> > upstream "cargo" crate updates it's internal set of dependencies.
> > 
> > Feel free to revert if there is a better way to fix it.
> 
> 
> My fix is to comment-out libgit2 dependency in cargo-c and then cargo-c gets compiled with vendored libgit2. And everyone's happy. :)
> 
> Kind regards,
> Adam

If no one else complains, I'm fine with that. 'cargo' has one of those annoying Cargo.toml files that gets regenerated and hence, it's a PITA to patch