pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: pkgsrc/audio/faad2



Module Name:    pkgsrc
Committed By:   wiz
Date:           Mon Nov 13 15:22:46 UTC 2023

Modified Files:
        pkgsrc/audio/faad2: Makefile PLIST buildlink3.mk distinfo
Added Files:
        pkgsrc/audio/faad2/patches: patch-CMakeLists.txt
Removed Files:
        pkgsrc/audio/faad2/patches: patch-configure.ac
            patch-frontend_Makefile.am patch-frontend_getopt.c
            patch-frontend_mp4read.c patch-libfaad_Makefile.am
            patch-libfaad_common.h patch-plugins_xmms_src_Makefile.am
            patch-plugins_xmms_src_libmp4.c

Log Message:
faad2: update to 2.11.0.

2.11.0:
        [ Eugène Filin ]
        * Fix incorrect variable initialization

        [ Eugene Kliuchnikov ]
        * CI/CD, build, etc

           - setup GitHub workflows; test build under MSVC, OSX, MSYS2, Linux
           - add CMake build system
           - additionally add Bazel build
           - remove automake and MSVC project files
           - add fuzzers that cover almost all decoder code
           - setup fuzzing for various builds: (no-)FIXED_POINT / (no-)DRM
           - remove dead code
           - address differes compilers warnings
           - move version to distingished place that different build systems can read

        * "Safe" bugs

           "Safe" means that it is unlikely to be exploited; those affect the decoded
           result for (most likely) extreme inputs. Some fixes are useful only for
           "FIXED_POINT" build, since it has more restrictions on intermediate values.

           - "negative range" in estimate_current_envelope
           - integer overflow in channel downmixing
           - integer overflow in estimate_envelope
           - integer overflows caused by "practical infinite" gain
           - integer overflows in HF adjustment code
           - several "left shift of negative value"
           - priming RNG to avoid using values that does not look random at all
           - do not drop the first frame of output; other decoders don't do this
           - touching uninitialized values in lt_update_state
           - touching uninitialized values in bit-reader buffers

        * "Almost Safe" bugs

           "Almost safe" means that those are unlinkly to be exploited; if those surface
           depends on build options / environment.

           - division by zero in HF (noise?) generator and scale factor adjustment
           - division by zero gen_rand_vector

        * "Unsafe" bugs

           "Unsafe" means that those can cause crash, or could somehow else be exploited.

           - CLI: accessing unallocated memory in mp4info (corrupted / zero-samples input) (CVE-2023-38857)
           - CLI: out-of-bounds when parsing mp4 header
           - CLI: crash because of wrong mp4 frame offset calculation (CVE-2023-38857)
           - error handling rvlc_decode_scale_factors (CPU bomb?)
           - null pointer dereference (in DRM + PS build)
           - index-out-of-bounds / stack-buffer-overflow in decode_sce_lfe
                 (for streams with PCE)
           - stack-buffer-overflow in pns_decode
           - null pointer derefernce (when channels change their type in the middle
                 of the stream)
           - infinite loop on currupted stream
           - add practial limits for scale factors; otherwise calculated NaN/Inf values
                 could confuse further logic, resulting in access-out-of-bounds
           - check sf_index in window_grouping_info to avoid access-out-of-bounds
           - clamp bs_pointer values to avoid access-out-of-bounds
           - infinite loop in fill_element
           - sanitize input values in ps_mix_phase to avoid access-out-of-bounds
           - fix internal decoder buffer size calculation to avoid heap-out-of-bounds
           - calculate channel length multiplier even if main channel is already allocated
                 to avoid heap-out-of-bounds
           - reserve enough slots for channels in decode_sce_lfe
                 to avoid heap-out-of-bounds

        [ David Korczynski ]
        * Fuzzing integration with oss-fuzz

        [ Steveice10 ]
        * Add define option to disable SBR/PS support
        * Fix coefficient table selection in tns_decode_coef


To generate a diff of this commit:
cvs rdiff -u -r1.59 -r1.60 pkgsrc/audio/faad2/Makefile
cvs rdiff -u -r1.17 -r1.18 pkgsrc/audio/faad2/PLIST
cvs rdiff -u -r1.14 -r1.15 pkgsrc/audio/faad2/buildlink3.mk
cvs rdiff -u -r1.35 -r1.36 pkgsrc/audio/faad2/distinfo
cvs rdiff -u -r0 -r1.1 pkgsrc/audio/faad2/patches/patch-CMakeLists.txt
cvs rdiff -u -r1.1 -r0 pkgsrc/audio/faad2/patches/patch-configure.ac \
    pkgsrc/audio/faad2/patches/patch-libfaad_common.h \
    pkgsrc/audio/faad2/patches/patch-plugins_xmms_src_Makefile.am \
    pkgsrc/audio/faad2/patches/patch-plugins_xmms_src_libmp4.c
cvs rdiff -u -r1.4 -r0 pkgsrc/audio/faad2/patches/patch-frontend_Makefile.am
cvs rdiff -u -r1.2 -r0 pkgsrc/audio/faad2/patches/patch-frontend_getopt.c
cvs rdiff -u -r1.3 -r0 pkgsrc/audio/faad2/patches/patch-frontend_mp4read.c \
    pkgsrc/audio/faad2/patches/patch-libfaad_Makefile.am

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/audio/faad2/Makefile
diff -u pkgsrc/audio/faad2/Makefile:1.59 pkgsrc/audio/faad2/Makefile:1.60
--- pkgsrc/audio/faad2/Makefile:1.59    Wed Apr 26 15:45:03 2023
+++ pkgsrc/audio/faad2/Makefile Mon Nov 13 15:22:45 2023
@@ -1,6 +1,6 @@
-# $NetBSD: Makefile,v 1.59 2023/04/26 15:45:03 wiz Exp $
+# $NetBSD: Makefile,v 1.60 2023/11/13 15:22:45 wiz Exp $
 
-DISTNAME=      faad2-2.10.1
+DISTNAME=      faad2-2.11.0
 CATEGORIES=    audio
 MASTER_SITES=  ${MASTER_SITE_GITHUB:=knik0/}
 GITHUB_TAG=    ${PKGVERSION_NOREV}
@@ -11,18 +11,14 @@ COMMENT=    AAC decoding library
 LICENSE=       gnu-gpl-v2
 
 USE_LANGUAGES=         c c++
-USE_LIBTOOL=           yes
-USE_TOOLS+=            autoconf automake autoreconf gmake
-GNU_CONFIGURE=         yes
-CONFIGURE_ARGS+=       --includedir=${PREFIX}/include/faad2
 
-LIBS+=                 -lm
 CPPFLAGS.SunOS+=       -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE=1
 
-post-extract:
-       ${MV} ${WRKSRC}/frontend/faad.man ${WRKSRC}/frontend/faad.1
+INSTALLATION_DIRS=     ${PKGMANDIR}/man1 ${PKGMANDIR}/man3
 
-pre-configure:
-       cd ${WRKSRC} && autoreconf -if
+post-install:
+       ${INSTALL_DATA} ${WRKSRC}/docs/libfaad.3 ${DESTDIR}${PREFIX}/${PKGMANDIR}/man3
+       ${INSTALL_DATA} ${WRKSRC}/frontend/faad.man ${DESTDIR}${PREFIX}/${PKGMANDIR}/man1/faad.1
 
+.include "../../devel/cmake/build.mk"
 .include "../../mk/bsd.pkg.mk"

Index: pkgsrc/audio/faad2/PLIST
diff -u pkgsrc/audio/faad2/PLIST:1.17 pkgsrc/audio/faad2/PLIST:1.18
--- pkgsrc/audio/faad2/PLIST:1.17       Fri May  8 13:03:20 2020
+++ pkgsrc/audio/faad2/PLIST    Mon Nov 13 15:22:45 2023
@@ -1,8 +1,13 @@
-@comment $NetBSD: PLIST,v 1.17 2020/05/08 13:03:20 nia Exp $
+@comment $NetBSD: PLIST,v 1.18 2023/11/13 15:22:45 wiz Exp $
 bin/faad
-include/faad2/faad.h
-include/faad2/neaacdec.h
-lib/libfaad.la
-lib/libfaad_drm.la
+include/faad.h
+include/neaacdec.h
+lib/libfaad.so
+lib/libfaad.so.2
+lib/libfaad.so.${PKGVERSION}
+lib/libfaad_drm.so
+lib/libfaad_drm.so.2
+lib/libfaad_drm.so.${PKGVERSION}
 lib/pkgconfig/faad2.pc
 man/man1/faad.1
+man/man3/libfaad.3

Index: pkgsrc/audio/faad2/buildlink3.mk
diff -u pkgsrc/audio/faad2/buildlink3.mk:1.14 pkgsrc/audio/faad2/buildlink3.mk:1.15
--- pkgsrc/audio/faad2/buildlink3.mk:1.14       Mon May  7 01:53:13 2012
+++ pkgsrc/audio/faad2/buildlink3.mk    Mon Nov 13 15:22:45 2023
@@ -1,4 +1,4 @@
-# $NetBSD: buildlink3.mk,v 1.14 2012/05/07 01:53:13 dholland Exp $
+# $NetBSD: buildlink3.mk,v 1.15 2023/11/13 15:22:45 wiz Exp $
 
 BUILDLINK_TREE+=       faad2
 
@@ -6,9 +6,8 @@ BUILDLINK_TREE+=        faad2
 FAAD2_BUILDLINK3_MK:=
 
 BUILDLINK_API_DEPENDS.faad2+=  faad2>=2.6.1
-BUILDLINK_ABI_DEPENDS.faad2+=  faad2>=2.6.1
+BUILDLINK_ABI_DEPENDS.faad2+=  faad2>=2.11.0
 BUILDLINK_PKGSRCDIR.faad2?=    ../../audio/faad2
-BUILDLINK_INCDIRS.faad2?=      include/faad2
 .endif # FAAD2_BUILDLINK3_MK
 
 BUILDLINK_TREE+=       -faad2

Index: pkgsrc/audio/faad2/distinfo
diff -u pkgsrc/audio/faad2/distinfo:1.35 pkgsrc/audio/faad2/distinfo:1.36
--- pkgsrc/audio/faad2/distinfo:1.35    Wed Apr 26 15:45:03 2023
+++ pkgsrc/audio/faad2/distinfo Mon Nov 13 15:22:45 2023
@@ -1,13 +1,6 @@
-$NetBSD: distinfo,v 1.35 2023/04/26 15:45:03 wiz Exp $
+$NetBSD: distinfo,v 1.36 2023/11/13 15:22:45 wiz Exp $
 
-BLAKE2s (faad2-2.10.1.tar.gz) = bf717748b2fefdb1c8897a7b8f7732a7420beef9deaf04b5bd84d47917d7385d
-SHA512 (faad2-2.10.1.tar.gz) = 8df69278350c68dd770c4bc482e42bc95eb04cd784eeea3f3fc58d615833c8b07dc3c72029bb7e5bfed612b7c1b8daefc9cb57be9789befb587120ef115e55b3
-Size (faad2-2.10.1.tar.gz) = 803488 bytes
-SHA1 (patch-configure.ac) = ed9d4e9d611d27d4add86884996a8e7fc001bc90
-SHA1 (patch-frontend_Makefile.am) = 32c8bede5773b2cb97777951b1a18366b4e10e3d
-SHA1 (patch-frontend_getopt.c) = 3eaf3e8318887eca49e354696cad1bd2c5bf5504
-SHA1 (patch-frontend_mp4read.c) = a72c20b69428809caf328850fd70a13ba5c82d41
-SHA1 (patch-libfaad_Makefile.am) = 7a5ff541d0b11a7d71d0ed5740bbf494501c6b7a
-SHA1 (patch-libfaad_common.h) = 60eccd8aebeb085760d6866f83ff5a613197918f
-SHA1 (patch-plugins_xmms_src_Makefile.am) = 4ba1dfefe1e351830ee990c711af6ac46db42c14
-SHA1 (patch-plugins_xmms_src_libmp4.c) = 7c6cd667999aab36efc9d713cf967c01b01916bf
+BLAKE2s (faad2-2.11.0.tar.gz) = e7394544aa994b0b78e5e2e80aad76a4d6d6a669595734bd360ecb122695d0b3
+SHA512 (faad2-2.11.0.tar.gz) = b85aab9b2d2afdca7096c999bcb7fabfccce4781760d9eb14d23fdd38691729927b09464708abf49a751e70c4475151ca14c5a7419b5cf4d9ec70c433dc86282
+Size (faad2-2.11.0.tar.gz) = 656610 bytes
+SHA1 (patch-CMakeLists.txt) = 28a4680cd053a96eba052d35e0c3661df077aaee

Added files:

Index: pkgsrc/audio/faad2/patches/patch-CMakeLists.txt
diff -u /dev/null pkgsrc/audio/faad2/patches/patch-CMakeLists.txt:1.1
--- /dev/null   Mon Nov 13 15:22:46 2023
+++ pkgsrc/audio/faad2/patches/patch-CMakeLists.txt     Mon Nov 13 15:22:45 2023
@@ -0,0 +1,15 @@
+$NetBSD: patch-CMakeLists.txt,v 1.1 2023/11/13 15:22:45 wiz Exp $
+
+Allow shared libraries.
+
+--- CMakeLists.txt.orig        2023-11-07 08:38:42.000000000 +0000
++++ CMakeLists.txt
+@@ -30,6 +30,8 @@ if(${CMAKE_SYSTEM_NAME} MATCHES "Darwin"
+   set(CMAKE_INSTALL_NAME_DIR "${CMAKE_INSTALL_PREFIX}/lib")
+ endif()
+ 
++option(BUILD_SHARED_LIBS "Build using shared libraries" ON)
++
+ # Extract version information
+ 
+ set(CAPTURE_PACKAGE_VERSION "[ \\t]*\"PACKAGE_VERSION\"[ \\t]*:[ \\t]\"(.*)\"")



Home | Main Index | Thread Index | Old Index