Re: CVS commit: pkgsrc/graphics/cairo

[Greg Troxel <gdt%lexort.com@localhost>]

"David H. Gutteridge" <david%gutteridge.ca@localhost> writes:

>> Module Name:    pkgsrc
>> Committed By:   nia
>> Date:           Fri Nov 17 08:17:04 UTC 2023
>> Modified Files:
>>        pkgsrc/graphics/cairo: Makefile
>> Log Message:
>> gnu99 just to be safe
>> To generate a diff of this commit:
>> cvs rdiff -u -r1.157 -r1.158 pkgsrc/graphics/cairo/Makefile
>> Please note that diffs are not public domain; they are subject to
>> the
>> copyright notices on the relevant files.
>> Modified files:
>> Index: pkgsrc/graphics/cairo/Makefile
>> diff -u pkgsrc/graphics/cairo/Makefile:1.157
>> pkgsrc/graphics/cairo/Makefile:1.158
>> --- pkgsrc/graphics/cairo/Makefile:1.157        Fri Nov 17 08:16:40
>> 2023
>> +++ pkgsrc/graphics/cairo/Makefile      Fri Nov 17 08:17:04 2023
>> @@ -1,4 +1,4 @@
>> -# $NetBSD: Makefile,v 1.157 2023/11/17 08:16:40 nia Exp $
>> +# $NetBSD: Makefile,v 1.158 2023/11/17 08:17:04 nia Exp $
>> DISTNAME=      cairo-1.18.0
>> CATEGORIES=    graphics
>> @@ -11,7 +11,7 @@ COMMENT=      Vector graphics library with cr
>> LICENSE=       gnu-lgpl-v2.1 AND mpl-1.1
>> # error: 'for' loop initial declarations are only allowed in C99
>> mode
>> -FORCE_C_STD=           c99
>> +FORCE_C_STD=           gnu99
>> USE_LANGUAGES=         c c++
>> USE_TOOLS+=            pkg-config
>
> Hi Nia,
>
> Shouldn't this set both FORCE_C_STD and USE_CC_FEATURES?

I would think we need gnu99 in USE_CC_FEATURES if we are going to
FORCE_C_STD it.

Also, I don't follow "just to be safe".  If cairo documents that it
needs gnu99, then that's how it is.   If it doesn't, and it needs it,
then it's buggy and someone(tm) should file a bug and include the URL.

As far as pkgsrc and c99, I can believe a c89 environment would fail,
but do we document this anywhere?  We should be operating on documented
requirements rather than lore.