CVS commit: pkgsrc/net/libcares

["Thomas Klausner" <wiz%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   wiz
Date:           Sat Dec 30 10:14:00 UTC 2023

Modified Files:
        pkgsrc/net/libcares: Makefile PLIST distinfo

Log Message:
libcares: update to 1.24.0.

Version 1.24.0 (16 Dec 2023)

GitHub (16 Dec 2023)
- [Brad House brought this change]

  ares_cancel() could trigger callback with wrong response code (#663)

  When doing ares_gethostbyname() or ares_getaddrinfo() with AF_UNSPEC, if ares_cancel() was called after one address class was returned but before the other address class, it would return 
ARES_SUCCESS rather than ARES_ECANCELLED.

  Test case has been added for this specific condition.

  Fixes Bug: #662
  Fix By: Brad House (@bradh352)

- [Brad House brought this change]

  rand: allow fallback from OS (#661)

  getrandom() can fail with ENOSYS if the libc supports the function but the kernel does not.

  Fixes Bug: #660
  Fix By: Brad House (@bradh352)

- [Brad House brought this change]

  1.24.0 release prep (#657)

Brad House (11 Dec 2023)
- reference alternative to ares_getsock() in docs

- tag some functions as deprecated in docs

- Coverity: fix allocation size as reported in new code

- remove dead code: ares_iphlpapi.h

- remove dead code: bitncmp

GitHub (9 Dec 2023)
- [Brad House brought this change]

  Use external GoogleTest instead of bundling it (#655)

  GoogleTest should be unbundled. Google changed their guidance a few years back and modern versions of google test cannot build the bundling code file.

  This PR also updates to use C++14 as is required by modern GoogleTest versions.

  Fixes Bug: #506
  Fix By: Brad House (@bradh352)

Brad House (8 Dec 2023)
- use IF_NAMESIZE instead of IFNAMSIZ to avoid warning

- remove redundant cast

- clang-format and fix one warning

GitHub (8 Dec 2023)
- [Brad House brought this change]

  Clean up some Windows-only warnings (#654)

  Windows was emitting some warnings due to datatype differences.

  Fix By: Brad House (@bradh352)

- [Brad House brought this change]

  Rewrite sortlist hand parser for memory safety and bugs (#653)

  The parser for the sortlist has been rewritten to use the ares__buf_*() functions. This also resolves some known bugs in accepting invalid sortlist entries which should have caused parse failures.

  Fixes Bug: #501
  Fix By: Brad House (@bradh352)

Brad House (8 Dec 2023)
- enhance timeout test case to make sure it will re-use a previously downed server

- enhance timeout test case

- SonarCloud: make const

GitHub (7 Dec 2023)
- [Brad House brought this change]

  increment failures on timeout (#651)

  As of c-ares 1.22.0, server timeouts were erroneously not incrementing server failures meaning the server in use wouldn't rotate.  There was apparently never a test case for this condition.

  This PR fixes the bug and adds a test case to ensure it behaves properly.

  Fixes Bug: #650
  Fix By: Brad House (@bradh352)

- [Brad House brought this change]

  Windows UBSAN tests (#649)

  Fix UBSAN error, and enable UBSAN testing in AppVeyor.

  Fixes Bug #648
  Fix By: Gisle Vanem (@gvanem)

- [Brad House brought this change]

  Support ipv6 link-local servers and %iface syntax (#646)

  Some environments may send router advertisements on a link setting their link-local (fe80::/10) address as a valid DNS server to the remote system.  This will cause a DNS entry to be created like 
`fe80::1%iface`, since all link-local network interfaces are technically part of the same /10 subnet, it must be told what interface to send packets through explicitly if there are multiple physical 
interfaces.

  This PR adds support for the %iface modifier when setting DNS servers via `/etc/resolv.conf` as well as via `ares_set_servers_csv()`.

  For MacOS and iOS it is assumed that libresolve will set the `sin6_scope_id` and should be supported, but my test systems don't seem to read the Router Advertisement for RDNSS link-local.  
Specifying the link-local dns server on MacOS via adig has been tested and confirmed working.

  For Windows, this is similar to MacOS in that the system doesn't seem to honor the RDNSS RA, but specifying manually has been tested to work.

  At this point, Android support does not exist.

  Fixes Bug #462
  Supersedes PR #463

  Fix By: Brad House (@bradh352) and Serhii Purik (@sergvpurik)

Brad House (4 Dec 2023)
- silence openwatcom warning due to qcache_max_ttl being unsigned

- ares__round_up_pow2() work around bogus warning

  On 32bit systems, a codeblock that would intentionally never
  be executed was emitting a warning.  Rework the code to
  prevent the warning.  More code, no behavior difference, but
  keeps people from complaining about the warning...

  Fixes Bug: #645
  Fix By: Brad House (@bradh352)

- try to move AC_USE_SYSTEM_EXTENSIONS

- Enable system extensions

  Certain defines are needed on some systems to enable functionality like
  pthread recursive mutexes.

  Fixes #644
  Fix By: Brad House (@bradh352)

- ares_init_options() with invalid options values should unset the option

  Apparently nodejs is relying on the above behavior for legacy reasons.  Add
  sanity checks to the various optmask parameters where it makes sense.

  See https://github.com/nodejs/node/pull/50800

  Fix By: Brad House (@bradh352)

- SonarCloud: silence bogus reported error

- clang-format

GitHub (2 Dec 2023)
- [Brad House brought this change]

  Nameserver parsing: replace another hand-written parser (#643)

  This replaces the nameserver parsing code with code that use ares__buf_*() in the name of memory safety.

  Fix By: Brad House (@bradh352)


To generate a diff of this commit:
cvs rdiff -u -r1.39 -r1.40 pkgsrc/net/libcares/Makefile
cvs rdiff -u -r1.23 -r1.24 pkgsrc/net/libcares/PLIST
cvs rdiff -u -r1.33 -r1.34 pkgsrc/net/libcares/distinfo

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/net/libcares/Makefile
diff -u pkgsrc/net/libcares/Makefile:1.39 pkgsrc/net/libcares/Makefile:1.40
--- pkgsrc/net/libcares/Makefile:1.39   Thu Dec  7 09:05:19 2023
+++ pkgsrc/net/libcares/Makefile        Sat Dec 30 10:14:00 2023
@@ -1,6 +1,6 @@
-# $NetBSD: Makefile,v 1.39 2023/12/07 09:05:19 wiz Exp $
+# $NetBSD: Makefile,v 1.40 2023/12/30 10:14:00 wiz Exp $
 
-DISTNAME=      c-ares-1.23.0
+DISTNAME=      c-ares-1.24.0
 PKGNAME=       ${DISTNAME:S/c-/libc/1}
 CATEGORIES=    net
 MASTER_SITES=  https://c-ares.haxx.se/download/

Index: pkgsrc/net/libcares/PLIST
diff -u pkgsrc/net/libcares/PLIST:1.23 pkgsrc/net/libcares/PLIST:1.24
--- pkgsrc/net/libcares/PLIST:1.23      Thu Dec  7 09:05:19 2023
+++ pkgsrc/net/libcares/PLIST   Sat Dec 30 10:14:00 2023
@@ -1,4 +1,4 @@
-@comment $NetBSD: PLIST,v 1.23 2023/12/07 09:05:19 wiz Exp $
+@comment $NetBSD: PLIST,v 1.24 2023/12/30 10:14:00 wiz Exp $
 bin/adig
 bin/ahost
 include/ares.h
@@ -14,7 +14,7 @@ lib/cmake/c-ares/c-ares-targets-noconfig
 lib/cmake/c-ares/c-ares-targets.cmake
 lib/libcares.so
 lib/libcares.so.2
-lib/libcares.so.2.9.0
+lib/libcares.so.2.10.0
 lib/libcares_static.a
 lib/pkgconfig/libcares.pc
 man/man1/adig.1
@@ -93,6 +93,7 @@ man/man3/ares_free_hostent.3
 man/man3/ares_free_string.3
 man/man3/ares_freeaddrinfo.3
 man/man3/ares_get_servers.3
+man/man3/ares_get_servers_csv.3
 man/man3/ares_get_servers_ports.3
 man/man3/ares_getaddrinfo.3
 man/man3/ares_gethostbyaddr.3

Index: pkgsrc/net/libcares/distinfo
diff -u pkgsrc/net/libcares/distinfo:1.33 pkgsrc/net/libcares/distinfo:1.34
--- pkgsrc/net/libcares/distinfo:1.33   Thu Dec  7 09:05:19 2023
+++ pkgsrc/net/libcares/distinfo        Sat Dec 30 10:14:00 2023
@@ -1,5 +1,5 @@
-$NetBSD: distinfo,v 1.33 2023/12/07 09:05:19 wiz Exp $
+$NetBSD: distinfo,v 1.34 2023/12/30 10:14:00 wiz Exp $
 
-BLAKE2s (c-ares-1.23.0.tar.gz) = fe08dc79a3809e5d531035041ce179f63c19019eea41a7a36c4eb69b4cb19aa5
-SHA512 (c-ares-1.23.0.tar.gz) = 0302fe809118bc81310c4f5ca4bbea3e2aee262da2c44ad6266d9da05e9326452f274508685974ff8aa6fce8332a2862008c12fbbc2917af258daa90b69567f0
-Size (c-ares-1.23.0.tar.gz) = 1681336 bytes
+BLAKE2s (c-ares-1.24.0.tar.gz) = 22d02b411022b0c750a8d5a7d2fcb350ca08009523839ca39d806dd6d5443fec
+SHA512 (c-ares-1.24.0.tar.gz) = 3701853e263de94daf19734185ad913848c19b825e0738926b418a54b0628ee1ac95a49ebfaa2ddf3eed74a7ef209e1a0a8f573df3e507ef1f11fcc53fc5eb68
+Size (c-ares-1.24.0.tar.gz) = 1368749 bytes