Re: CVS commit: pkgsrc/databases/gdbm

[Aleksey Cheusov <a.cheusov%yandex.ru@localhost>]

On May 1, 2024 10:37:28 PM UTC, Jonathan Perkin <jperkin%mnx.io@localhost> wrote:
>* On 2024-05-01 at 23:06 BST, Aleksey Cheusov wrote:
>
>> Module Name: pkgsrc
>> Committed By:        cheusov
>> Date:                Wed May  1 22:06:33 UTC 2024
>> 
>> Modified Files:
>>      pkgsrc/databases/gdbm: Makefile PLIST
>> Added Files:
>>      pkgsrc/databases/gdbm: options.mk
>> 
>> Log Message:
>> Add option "nls" enabled by default
>
>Again, all of these changes are wrong.  The buildlink3 logic must match that of the package, including checking PKG_BUILD_OPTIONS.
>
>All of these commits are just breaking every package that depends on them.
>

Could you explain please what exactly is wrong? I tested my changes on NetBSD and Linux with and without nls option. Everything worked just fine.