* On 2024-05-24 at 13:07 BST, Greg Troxel wrote:
Module Name: pkgsrc
Committed By: gdt
Date: Fri May 24 11:57:24 UTC 2024
Modified Files:
pkgsrc/geography/qgis: Makefile
Log Message:
geography/qgis: Reorder cmake/build.mk with TOOLS
This is where it obviously belongs, not being a bl3 file, and there is
no documentation articulating why it should be anywhere in particular.
I wouldn't recommend doing this, there are at least two variables that are not lazily parsed in build.mk and ordering will affect how they behave (CMAKE_REQD and CMAKE_GENERATOR). It may also affect the target overrides, I don't recall off-hand if they are affected by ordering.
While there might not be specific documentation about this, there should be general documentation stating that includes should always come last unless there is a specific reason for them not to (usually because you need to test for a variable that they set).
-- Jonathan Perkin - mnx.io - pkgsrc.smartos.org Open Source Complete Cloud www.tritondatacenter.com