Re: CVS commit: pkgsrc/misc/calibre

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Mon, Aug 12, 2024 at 08:26:38PM +0200, Adam Ciarciński wrote:
> > Log Message:
> > Remove PYTHON_VERSIONS_INCOMPATIBLE 312 from calibre
> > 
> > Appears to build and run fine with python312, and this avoids the
> > default setup failing to build due to py311-sip6-6.8.6 conflicting
> > with py312-sip6-6.8.6 now the default python version is 3.12
> > 
> > 
> > To generate a diff of this commit:
> > cvs rdiff -u -r1.302 -r1.303 pkgsrc/misc/calibre/Makefile
> > 
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.
> > 
> > Modified files:
> > 
> > Index: pkgsrc/misc/calibre/Makefile
> > diff -u pkgsrc/misc/calibre/Makefile:1.302 pkgsrc/misc/calibre/Makefile:1.303
> > --- pkgsrc/misc/calibre/Makefile:1.302 Mon Jun  3 03:57:38 2024
> > +++ pkgsrc/misc/calibre/Makefile Mon Aug 12 16:25:50 2024
> > @@ -1,4 +1,4 @@
> > -# $NetBSD: Makefile,v 1.302 2024/06/03 03:57:38 ryoon Exp $
> > +# $NetBSD: Makefile,v 1.303 2024/08/12 16:25:50 abs Exp $
> > 
> > # Needs update to 6.9.0
> > DISTNAME= calibre-5.44.0
> > @@ -45,8 +45,6 @@ TOOL_DEPENDS+= xdg-utils>=1.0.2:../../mi
> > 
> > EXTRACT_USING= bsdtar
> > 
> > -PYTHON_VERSIONS_INCOMPATIBLE= 27 312 # as of 5.x
> > -
> > USE_LANGUAGES= c c++
> > FORCE_CXX_STD= c++17
> > USE_LIBTOOL= yes
> 
> You should have kept PYTHON_VERSIONS_INCOMPATIBLE=27.
> 

Why? Nowadays packages have to set PYTHON_27_ACCEPTED so that Python
2.7 is even considered.
 Thomas