CVS commit: pkgsrc/ham/gnuradio-core

["Greg Troxel" <gdt%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   gdt
Date:           Tue Aug 20 17:49:10 UTC 2024

Modified Files:
        pkgsrc/ham/gnuradio-core: Makefile.common

Log Message:
gnuradio-core: Add comment about clearing CMAKE_CONFIGURE_ARGS

It seems buggy to clear this, and needs an explanation and argument of
correctness.


To generate a diff of this commit:
cvs rdiff -u -r1.52 -r1.53 pkgsrc/ham/gnuradio-core/Makefile.common

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/ham/gnuradio-core/Makefile.common
diff -u pkgsrc/ham/gnuradio-core/Makefile.common:1.52 pkgsrc/ham/gnuradio-core/Makefile.common:1.53
--- pkgsrc/ham/gnuradio-core/Makefile.common:1.52       Tue Aug 20 17:46:17 2024
+++ pkgsrc/ham/gnuradio-core/Makefile.common    Tue Aug 20 17:49:10 2024
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile.common,v 1.52 2024/08/20 17:46:17 gdt Exp $
+# $NetBSD: Makefile.common,v 1.53 2024/08/20 17:49:10 gdt Exp $
 # This Makefile fragment is included in the package Makefiles for
 # GNU Radio distributed packages (they all share common configure and build
 # settings).
@@ -88,6 +88,9 @@ CXXFLAGS.SunOS+=      -pthreads
 INSTALLATION_DIRS+=    ${EGDIR}
 
 # --------       R E S E T  CMAKE_CONFIGURE_ARGS  H E R E  -------------
+
+# \todo Explain why this is safe.  Lots of mk fragments add content,
+# and clearing that seems wrong.
 CMAKE_CONFIGURE_ARGS=
 
 CMAKE_CONFIGURE_ARGS+= -DENABLE_GNURADIO_RUNTIME=ON