CVS commit: pkgsrc/finance

["Taylor R Campbell" <riastradh%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   riastradh
Date:           Thu Sep 12 19:13:14 UTC 2024

Modified Files:
        pkgsrc/finance/ledger: Makefile
        pkgsrc/finance/ledger32: Makefile

Log Message:
finance/ledger, finance/ledger32: Mark incompatible with Python 3.12.

These still use PyUnicode_GET_SIZE, which was removed in Python 3.12:

https://peps.python.org/pep-0623/

Set Python_EXECUTABLE explicitly so they don't inadvertently pick up
bin/python3.12.

No revbump because finance/ledger and finance/ledger32 currently
don't build at all with pkgsrcwide default of Python 3.12.

The issue has been fixed upstream so it can probably be removed in
the next finance/ledger update:

https://github.com/ledger/ledger/issues/2332

And with any luck, finance/ledger32 can be removed eventually, now
that upstream has acknowledged the bug that motivated it:

https://github.com/ledger/ledger/issues/2355
(dup of https://github.com/ledger/ledger/issues/2318)


To generate a diff of this commit:
cvs rdiff -u -r1.34 -r1.35 pkgsrc/finance/ledger/Makefile
cvs rdiff -u -r1.4 -r1.5 pkgsrc/finance/ledger32/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/finance/ledger/Makefile
diff -u pkgsrc/finance/ledger/Makefile:1.34 pkgsrc/finance/ledger/Makefile:1.35
--- pkgsrc/finance/ledger/Makefile:1.34 Thu Sep 12 17:01:25 2024
+++ pkgsrc/finance/ledger/Makefile      Thu Sep 12 19:13:14 2024
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.34 2024/09/12 17:01:25 riastradh Exp $
+# $NetBSD: Makefile,v 1.35 2024/09/12 19:13:14 riastradh Exp $
 
 DISTNAME=      ledger-3.3.2
 PKGREVISION=   6
@@ -18,6 +18,11 @@ USE_CXX_FEATURES+=   c++11
 USE_LANGUAGES= c c++
 TEST_TARGET=   check
 
+# https://github.com/ledger/ledger/issues/2332
+PYTHON_VERSIONS_INCOMPATIBLE=  312     # PyUnicode_GET_SIZE
+
+CMAKE_CONFIGURE_ARGS+= -DPython_EXECUTABLE:STRING=${TOOL_PYTHONBIN:Q}
+
 .include "options.mk"
 
 REPLACE_PYTHON+=       contrib/getquote-uk.py

Index: pkgsrc/finance/ledger32/Makefile
diff -u pkgsrc/finance/ledger32/Makefile:1.4 pkgsrc/finance/ledger32/Makefile:1.5
--- pkgsrc/finance/ledger32/Makefile:1.4        Thu Sep 12 17:01:25 2024
+++ pkgsrc/finance/ledger32/Makefile    Thu Sep 12 19:13:14 2024
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.4 2024/09/12 17:01:25 riastradh Exp $
+# $NetBSD: Makefile,v 1.5 2024/09/12 19:13:14 riastradh Exp $
 
 DISTNAME=      ledger-3.2.1
 PKGREVISION=   3
@@ -20,6 +20,10 @@ USE_CXX_FEATURES=    c++11
 USE_LANGUAGES= c c++
 TEST_TARGET=   check
 
+PYTHON_VERSIONS_INCOMPATIBLE=  312     # PyUnicode_GET_SIZE
+
+CMAKE_CONFIGURE_ARGS+= -DPython_EXECUTABLE:STRING=${TOOL_PYTHONBIN:Q}
+
 .include "options.mk"
 
 REPLACE_PYTHON+=       acprep