Re: libcurl.pc now relies on inexistent heimdal-gssapi.pc (and ldap.pc) in NetBSD (was: CVS commit: pkgsrc/www)

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Wed, Nov 06, 2024 at 03:07:48PM +0100, Leonardo Taccari wrote:
> Hello Thomas,
> 
> Thomas Klausner writes:
> > Module Name:        pkgsrc
> > Committed By:       wiz
> > Date:               Wed Nov  6 08:19:26 UTC 2024
> >
> > Modified Files:
> >     pkgsrc/www/curl: Makefile Makefile.common PLIST distinfo
> >     pkgsrc/www/curl/patches: patch-curl-config.in
> >     pkgsrc/www/libcurl-gnutls: Makefile
> >
> > Log Message:
> > *curl*: update to 8.11.0
> > [...]
> > This release includes the following bugfixes:
> >
> >  [...]
> >  o configure: add GSS to `libcurl.pc` `Depends:` [126]
> >  [...]
> 
> At least on NetBSD, where "gssapi" option is unconditionally enabled
> this breaks `libcurl` pkgconfig file when invoking via the `--cflags`:
> 
>  $ pkgconf --cflags libcurl
>  Package heimdal-gssapi was not found in the pkg-config search path.
>  Perhaps you should add the directory containing `heimdal-gssapi.pc'
>  to the PKG_CONFIG_PATH environment variable
>  Package 'heimdal-gssapi', required by 'libcurl', not found
> 
> ...and that will likely breaks all packages that are relying on libcurl
> pkgconfig file.

Why isn't

.if ${PKG_BUILD_OPTIONS.curl:Mgssapi}
.  include "../../mk/krb5.buildlink3.mk"
.endif

in the buildlink3.mk enough to fix this?

> As a quick workaround I propose to not treat NetBSD special and do
> not enable gssapi option by default. We should then investigate how to
> possibly avoid that (I think it is possible to provide fake .pc files
> but I have not fully investigated yet, sorry!).
> 
> OK?

Fine with me.
 Thomas