Re: libxml2 needs converters/libiconv on NetBSD > 1.6, DragonFlyBSD and Solaris

[joerg%britannica.bec.de@localhost]

On Sun, Apr 02, 2006 at 08:52:31PM +0200, Christian Biere wrote:
> joerg%britannica.bec.de@localhost wrote:
> > > At this point, libxml2 and thus libxslt/xsltproc are broken on several
> > > pkgsrc platforms where non-western code sets are concerned. Shouldn't
> > > we address this in the short term by using converters/libiconv?
>  
> > Or you could try the attached patch :-)
> > +--- encoding.c.orig        2005-09-02 12:23:19.000000000 +0000
> > ++++ encoding.c
> > +@@ -1709,6 +1709,8 @@ xmlIconvWrapper(iconv_t cd, unsigned cha
> > +         *inlen = 0;
> > +         *outlen = 0;
> > +     }
> > ++    if (ret > 0)
> > ++  return -2;
> > +     if ((icv_inlen != 0) || (ret == -1)) {
> > + #ifdef EILSEQ
> > +         if (errno == EILSEQ) {
> 
> I think you have to correct "*inlen" and "*outlen" for bug-compatibility
> as well.

Sure, for a full fix. First part is about getting it to report problems
only. The correction of *inlen and *outlen is a lot more work.

Joerg