Re: pkgsrc policies

["Steven M. Bellovin" <smb%cs.columbia.edu@localhost>]

On Sun, 6 Aug 2006 05:44:49 +0000, Roland Illig <rillig%NetBSD.org@localhost> 
wrote:

> On Sun, Aug 06, 2006 at 12:42:59AM -0400, Perry E. Metzger wrote:
> > 
> > Roland Illig <rillig%NetBSD.org@localhost> writes:
> > > Christos Zoulas wrote:
> > >> On Aug 5,  8:00am, veego%NetBSD.org@localhost (Bernd Ernesti) wrote:
> > >> -- Subject: Missing release notes (was: CVS commit: 
> > >> pkgsrc/devel/id-utils)
> > >> | Hmm, we have a policy for pkgsrc to mention what changed in the
> > >> cvs commit mail
> > >> | and this is an update from 3.2 to 4.1 and you removed a lot of patches.
> > >> I did not remove a lot of patches. I just merged multiple patches to
> > >> the same file in one patch.
> > >
> > > Hmm, we have an (unwritten?) policy for pkgsrc to only patch one file
> > > per patch file.
> > 
> > He merged multiple patches for a single file to a single patch. How
> > does this violate the stated policy?
> 
> Oh, I misread that. But:
> 
> $ pkglint
> WARN: patches/patch-ai: Contains patches for 2 files, should be only one.
> 

That's certainly a bug.  Here's what pkgsrc.txt says (Section 9.3): 

   Furthermore, do not put changes for more than one file
   into a single patch file, as this will make future modifications more
   difficult.

   Similar, a file should be patched at most once, not several times by
   several different patches. If a file needs several patches, they should
   be combined into one file.



                --Steven M. Bellovin, http://www.cs.columbia.edu/~smb