Re: CVS commit: pkgsrc/sysutils/apcupsd

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Fri, Jun 15, 2007 at 10:00:14PM +0200, Bernd Ernesti wrote:
> Huh?
> platforms/etc/Makefile tries to install this version and not the outdated
> apcupsd.master.conf file.

Hum, you're right.

> 
> > But it's patched so that it acually works.
> 
> But as one can see from the head it is based on 3.10.6, but we are now at
> 3.14.1.
> 
> Attached is the diff between the 'patched' apcupsd.master.conf and
> the generated platforms/etc/apcupsd.conf.
> 
> You will see that the 'patched' file missed some options, e.g. SCRIPTDIR
> PWRFAILDIR, NOLOGINDIR, ONBATTERYDELAY

OK, I'll look at this one.

> 
> > > file instead of platforms/etc/apcupsd.conf and you didn't patch the rc.d
> > > script.
> > 
> > No. I'm not sure it's a good idea to make it rc.d-specific, and certainly
> > a very bad one to add the SHUTDOWN keyword.
> 
> But adding the needed keywords made it work with rc.d and it doesn't break
> anything else (if you leave the SHUTDOWN keyword out).

Are you talking about just the keywords, or a new script fully integrated with
the rc.d framework ? pkg/36192 is about a new script.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--