Re: PLIST wrong in pkgsrc/net/kdenetwork3

["Johnny C. Lam" <jlam%pkgsrc.org@localhost>]

On Sat, Jun 23, 2007 at 07:54:11AM +0200, Bernd Ernesti wrote:
> On Sat, Jun 23, 2007 at 05:40:17AM +0000, Johnny C. Lam wrote:
> > On Sat, Jun 23, 2007 at 07:10:53AM +0200, Bernd Ernesti wrote:
> > > 
> > > I had a problem while deleting this package with pkg_delete:
> > > 
> > > pkg_delete: unable to completely remove directory 
> > > '/usr/pkg/share/kde/apps/kopete/styles/Clear/Contents/Resources'
> > > pkg_delete: unable to completely remove directory 
> > > '/usr/pkg/share/kde/apps/kopete/styles/Clear/Contents'
> > > pkg_delete: unable to completely remove directory 
> > > '/usr/pkg/share/kde/apps/kopete/styles/Clear'
> > > pkg_delete: unable to completely remove directory 
> > > '/usr/pkg/share/kde/apps/kopete/styles'
> > > pkg_delete: unable to completely remove directory 
> > > '/usr/pkg/share/kde/apps/kopete'
> > > Executing `/bin/rmdir /usr/pkg/share/kde/apps/knewsticker 2>/dev/null || 
> > > true'
> > > pkg_delete: couldn't entirely delete package `kdenetwork-3.5.7'
> > > (perhaps the packing list is incorrectly specified?)
> > > 
> > > It took me a while to figure out what was wrong:
> > > 
> > > diff -b -u -r1.26 PLIST
> > > --- PLIST 23 May 2007 13:10:04 -0000      1.26
> > > +++ PLIST 23 Jun 2007 05:06:49 -0000
> > > @@ -1726,13 +1726,13 @@
> > >  @dirrm share/kde/apps/kopete/styles/Gaim/Contents
> > >  @dirrm share/kde/apps/kopete/styles/Gaim
> > >  @dirrm share/kde/apps/kopete/styles/Clear/Contents/Resources/images
> 
> > > +@dirrm share/kde/apps/kopete/styles/Clear/Contents/Resources/Variants
> 
> > >  @dirrm share/kde/apps/kopete/styles/Clear/Contents/Resources/Outgoing
> > >  @dirrm share/kde/apps/kopete/styles/Clear/Contents/Resources/Incoming
> > >  @dirrm share/kde/apps/kopete/styles/Clear/Contents/Resources
> > >  @dirrm share/kde/apps/kopete/styles/Clear/Contents
> > >  @dirrm share/kde/apps/kopete/styles/Clear
> > >  @dirrm share/kde/apps/kopete/styles/Clean/Contents/Resources/images
> 
> > > -@dirrm share/kde/apps/kopete/styles/Clear/Contents/Resources/Variants
>                                              ^
> 
> > >  @dirrm share/kde/apps/kopete/styles/Clean/Contents/Resources/Outgoing
> > >  @dirrm share/kde/apps/kopete/styles/Clean/Contents/Resources/Incoming
> > >  @dirrm share/kde/apps/kopete/styles/Clean/Contents/Resources
> > > 
> > > I haven't tested it yet, but it looks like this will fix the problem.
> > 
> > In the error output you give about, I don't see a message that says
> > pkg_delete tried to remove a nonexistent directory, so why do you need
> > to remove the .../Clean/.../Variants line from the PLIST?
> 
> Take a closer look then you see why it took me a while to see the problem.
> 
> Hint: s/r/n/
> 
> Removing a directory while it is not empty doesn't work and thats the case
> here, because of the wrong oder of @drirm

No, I can see why you added a @dirrm for .../Clear/.../Variants, but
why do you need to remove the @dirrm for .../Clean/.../Variants?  I
don't see any pkg_delete error that says it tried to remove a nonexistent
.../Clean/.../Variants directory.

        Cheers,

        -- Johnny Lam <jlam%pkgsrc.org@localhost>