Re: bootstrap can trigger bug in /bin/sh of OpenSolaris

["Jörn Clausen" <joernc%googlemail.com@localhost>]

Hi!

On Thu, Oct 30, 2008 at 11:28 PM, Joerg Sonnenberger
<joerg%britannica.bec.de@localhost> wrote:
> On Thu, Oct 30, 2008 at 10:16:51PM +0100, J?rn Clausen wrote:
>> - Remove the path check in bootstrap. Or at least soften it. It
>> rejects a lot of paths someone might have a good reason to use. I
>> think the check for an absolute path is totally sufficient.
>
> One major reason for the check is to prevent e.g. PREFIX with spaces and
> other fancy characters. Which is not that unlikely as it seems.

Then maybe the check could test for exactly this character. And maybe
two or three others, that are deemed dangerous within pkgsrc.

For what it's worth: Changing the regex to

   *[!A-Za-z0-9_./-]*

i.e. moving the literal "-" to the end, makes it behave in
OpenSolaris' Bourne Shell as expected. Now paths containing a dash are
allowed again.

-- 
Joern Clausen
joernc%gmail.com@localhost
http://www.oe-files.de/oefiles/
http://thebloeg.blogspot.com/