Re: Testers required: glib2 Solaris fix

["Jörn Clausen" <joernc%googlemail.com@localhost>]

Hi!

On Tue, Nov 25, 2008 at 11:53 AM, Jonathan Perkin
<jonathan%perkin.org.uk@localhost> wrote:
> devel/glib2 is broken on my sol10u6/studio12 system, due to
> patches/patch-aj which sets _XOPEN_SOURCE=600.
>
> This was added to work around some Solaris stuff years ago but very much
> feels like the wrong solution, and now it actively breaks on my system
> with:
>
>  "/usr/include/sys/feature_tests.h", line 336: #error: "Compiler or options 
> invalid; UNIX 03 and POSIX.1-2001 applications require the use of c99"
>
> I think this patch was added before we fixed sunpro.mk to use the correct
> -xc99 flags, and now even with the correct flags set it still breaks.
>
> I'd like to remove it, but I don't know what other platforms may break, so
> want to encourage people, especially with older releases of Solaris/Sun
> Studio to remove it and test the build.

I just tried to remove this patch on two Solarises 10
(Generic_120012-14 and Generic_137111-07, whenever that is), one using
the combination gcfss with glib2-2.18.0 from 2008Q3, the other one
using lang/gcc34 with glib2-2.18.2 from CVS. Both fail with

 gcc -DHAVE_CONFIG_H -I. -I..
-I/software/local/pkgsrc/source/pkgsrc-cvs/pkgsrc/devel/glib2.new/work.spare4200/.buildlink/include
-DG_LOG_DOMAIN=\"GLib\" -DG_DISABLE_CAST_CHECKS -DG_DISABLE_DEPRECATED
-DGLIB_COMPILATION -DPCRE_STATIC
-DPREFIX=\"/usr/local/pkgsrc/pkgsrc-cvs\" -DPKGLOCALEDIR=\"lib\"
-DPKG_SYSCONFDIR=\"/usr/local/pkgsrc/pkgsrc-cvs/etc\"
-I/software/local/pkgsrc/source/pkgsrc-cvs/pkgsrc/devel/glib2.new/work.spare4200/.buildlink/gcc34/include
-DG_DISABLE_SINGLE_INCLUDES -D_REENTRANT -D_PTHREADS -O -Wall -MT
giounix.lo -MD -MP -MF .deps/giounix.Tpo -c giounix.c  -fPIC -DPIC -o
.libs/giounix.o
In file included from /usr/include/sys/types.h:18,
                 from giounix.c:38:
/usr/include/sys/feature_tests.h:332:2: #error "Compiler or options
invalid for pre-UNIX 03 X/Open applications         and pre-2001 POSIX
applications"

I am quite sure I compiled glib2-2.18.0 (i.e. from 2008Q3) on one of
these machines with Sun Studio 12 without any problems.

I just tried to reproduce my problem with 2.18.2 (with patch-aj) I
briefly mentioned in another mail, but now I can compile this version.
Very strange...

-- 
Joern Clausen
joernc%gmail.com@localhost
http://www.oe-files.de/oefiles/
http://thebloeg.blogspot.com/