Re: skey in pkgsrc won't generate SHA1 passwords, build troubles

["OBATA Akio" <obache%netbsd.org@localhost>]

Hi,

On Thu, 08 Jan 2009 03:43:10 +0900, Ed Ravin <eravin%panix.com@localhost> wrote:

> I've discovered an embarrasing problem in pkgsrc.  The "skey"
> package (skey-1.1.5) does not include the fix for NetBSD bug lib/12045:
>
>  http://www.netbsd.org/cgi-bin/query-pr-single.pl?number=12045
> 
> which means SHA-1 passswords are always generated incorrectly.  This
> bug was fixed back in 2001.  Worse yet, since MacPorts uses NetBSD's
> skey-1.1.5 from pkgsrc, it's broken there too.

I don't know that the distfile of current security/skey came from,
but should we cut-off skey source code from current NetBSD source tree
and create new distfile?

> cc -O2 -DHAVE_CONFIG_H  -DSENDMAIL=\"/usr/sbin/sendmail\"
> -DSKEYKEYS=\"/usr/pkg/etc/skeykeys\"   -c -o rmd160hl.o rmd160hl.c
> In file included from config.h:157,
>                  from rmd160hl.c:21:
> defines.h:67:15: warning: extra tokens at end of #ifdef directive
> rmd160hl.c: In function 'RMD160File':
> rmd160hl.c:55: error: argument 'filename' doesn't match prototype
> /usr/include/rmd160.h:51: error: prototype declaration
> gmake: *** [rmd160hl.o] Error 1
> *** Error code 2

It's PR 39872 and should be fixed by skey-1.1.5nb3.

-- 
"Of course I love NetBSD":-)
OBATA Akio / obache%NetBSD.org@localhost