Re: HEADS UP: libtool update

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Thu, Dec 17, 2009 at 08:54:39PM +0900, OBATA Akio wrote:
> On Thu, 17 Dec 2009 20:34:44 +0900, Joerg Sonnenberger 
> <joerg%britannica.bec.de@localhost> wrote:
> 
> >Not 100%. OK, better, but slightly more intrusive patch attached.
> 
> Unfortunately, it does not work as expected, broken again...

GRMBL. The problem is that this is a heisenbug -- minimal changes avoid
it. Can you try the attached patch and check for the instances of ^"$?
None of the trivial variable assignments should be left with a newline.

Joerg

Index: distinfo
===================================================================
RCS file: /home/joerg/repo/netbsd/pkgsrc/devel/libtool/distinfo,v
retrieving revision 1.78
diff -u -p -r1.78 distinfo
--- distinfo    17 Dec 2009 00:53:52 -0000      1.78
+++ distinfo    17 Dec 2009 12:31:40 -0000
@@ -4,6 +4,6 @@ SHA1 (libtool-2.2.6b.tar.gz) = 5afa73c8e
 RMD160 (libtool-2.2.6b.tar.gz) = 02d8c1460946a1a0054b3ccb6b54d2404b53c2ef
 Size (libtool-2.2.6b.tar.gz) = 2347317 bytes
 SHA1 (patch-aa) = 84e916bf868ada2ebeffe940f03537fadd751751
-SHA1 (patch-ab) = 9253f12bc5e0c0576885a374c76b821c28ae2ede
+SHA1 (patch-ab) = 7b88703844ca0b2906b1ad81a431a4bfc125445e
 SHA1 (patch-ac) = 8187bfc8436d2d7477a6a33c925c6d141804ad65
 SHA1 (patch-ad) = 51ede8bef293d566cd359efa52e6cd04f4a380ec
Index: patches/patch-ab
===================================================================
RCS file: /home/joerg/repo/netbsd/pkgsrc/devel/libtool/patches/patch-ab,v
retrieving revision 1.66
diff -u -p -r1.66 patch-ab
--- patches/patch-ab    17 Dec 2009 00:53:52 -0000      1.66
+++ patches/patch-ab    17 Dec 2009 12:31:15 -0000
@@ -1,5 +1,8 @@
 $NetBSD: patch-ab,v 1.66 2009/12/17 00:53:52 joerg Exp $
 
+The last two chunks work around bugs in ksh on NetBSD.
+The problem manifests with wl and no_builtin_flag containing newlines.
+
 --- configure.orig     2009-12-17 01:29:54.000000000 +0100
 +++ configure
 @@ -5293,6 +5293,13 @@ else
@@ -835,3 +838,23 @@ $NetBSD: patch-ab,v 1.66 2009/12/17 00:5
  
  lt_cv_prog_compiler_c_o_RC=yes
  
+@@ -24427,6 +24441,9 @@
+ LTCFLAGS='$LTCFLAGS'
+ compiler='$compiler_DEFAULT'
+ 
++printf "%s" "$lt_prog_compiler_wl" > /dev/null
++printf "%s" "$lt_prog_compiler_no_builtin_flag" > /dev/null
++
+ # Quote evaled strings.
+ for var in SED \
+ GREP \
+@@ -24711,6 +24729,9 @@
+   ;;
+ esac
+ 
++printf "%s" "$lt_prog_compiler_wl" > /dev/null
++printf "%s" "$lt_prog_compiler_no_builtin_flag" > /dev/null
++
+ ac_aux_dir='$ac_aux_dir'
+ xsi_shell='$xsi_shell'
+ lt_shell_append='$lt_shell_append'