Re: Heads Up: make install

[Julio Merino <jmmv%NetBSD.org@localhost>]

On Thu, Feb 25, 2010 at 12:30 PM, OBATA Akio <obata%lins.jp@localhost> wrote:
> On Thu, 25 Feb 2010 21:10:39 +0900, Joerg Sonnenberger
> <joerg%britannica.bec.de@localhost> wrote:
>
>> On Thu, Feb 25, 2010 at 02:33:54PM +0900, OBATA Akio wrote:
>>>
>>> >Works the same as "make reinstall" for the non-DESTDIR case without
>>> >modifying /usr/pkg, e.g.
>>> >       - remove cookies for install and package phase
>>> >       - run stage-install
>>> >       - run package
>>> >       - run package-install
>>>
>>> Thanks to force to create and install (maybe) broken packages when
>>> testing package installation.
>>
>> I'm not sure I understand your problem. You want "make reinstall" to
>> only run stage-install for the DESTDIR case? I don't changing that, but
>> I should add that it only matters if the install stage does not fail.
>> This includes all the cecks.
>
> You are superman, so probably can't understand ordinary man's job.
> For me, to create/update packages, try to install, fix PLIST,
> and try to reinstall, fixes permissions, and try to reinstall, and so on.
> And also poor man, no highspeed machine, so I don't want to rebuild time
> after time.

Unless something is very wrong, "make install" now will not install
broken packages.  "make package" has always failed if the list of
installed files is incorrect, so you can still go through your same
procedure when updating packages.  I don't see the issue.

Joerg's change only makes "make install" DTRT when using destdir and
leaves all previous behavior unaltered.  The previous situation was
non-intuitive (to the point of being considered broken by some).
Joerg, thanks for the change!

-- 
Julio Merino