Re: New courier packages

[Brian Candler <B.Candler%pobox.com@localhost>]

On Mon, Jun 14, 2010 at 12:48:34PM +0200, Fredrik Pettai wrote:
> The courier suite has been updated again.
> Please try this updated patch, and let me know if something breaks...
> http://www.netbsd.org/~pettai/courier-pkg-bundle.patch

I've tested that it compilation under Linux (Ubuntu Hardy) with a completely
fresh pkgsrc head checkout, the above patch and bootstrap --unprivileged.
Building meta-pkgs/courier went quite a long way, and aborted here:

...
libnumlib.la `cat ../../threadlib/libthread.dep`  
libtool: link: gcc -I.. -I./.. -I./../libs -I./../.. -I../.. -I../../liblock 
-Wall -Wno-error 
-I/data/v/build/pkgsrc/mail/courier-mta/work/.buildlink/include/db4 
-I/data/v/build/pkgsrc/mail/courier-mta/work/.buildlink/include 
-Wl,-R/home/candlerb/pkg/lib -o dupfilter dupfilter.o duphash.o msghash.o  
-L/data/v/build/pkgsrc/mail/courier-mta/work/.buildlink/lib 
libfilter/libfilter.a ../../md5/.libs/libmd5.a ../libs/.libs/libcommon.a 
../libs/.libs/libcourier.a ../../liblock/.libs/liblock.a 
../../threadlib/libthreadlib.a ../../numlib/.libs/libnumlib.a -lpthread
gcc -DHAVE_CONFIG_H -I.   -I/home/candlerb/pkg/include/db4 -I/usr/include 
-I/home/candlerb/pkg/include  -I.. -I./.. -I./../libs -I./../.. -I../.. 
-I../../liblock -Wall -Wno-error -I/home/candlerb/pkg/include/db4 
-I/usr/include -I/home/candlerb/pkg/include -MT courierfilter.o -MD -MP -MF 
.deps/courierfilter.Tpo -c -o courierfilter.o courierfilter.c
courierfilter.c: In function 'main':
courierfilter.c:377: error: expected expression before ',' token
make[5]: *** [courierfilter.o] Error 1
make[5]: Leaving directory 
`/data/v/build/pkgsrc/mail/courier-mta/work/courier-0.65.0/courier/filters'
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory 
`/data/v/build/pkgsrc/mail/courier-mta/work/courier-0.65.0/courier/filters'
make[3]: *** [all] Error 2
make[3]: Leaving directory 
`/data/v/build/pkgsrc/mail/courier-mta/work/courier-0.65.0/courier/filters'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory 
`/data/v/build/pkgsrc/mail/courier-mta/work/courier-0.65.0/courier'
make[1]: *** [all] Error 2
make[1]: Leaving directory 
`/data/v/build/pkgsrc/mail/courier-mta/work/courier-0.65.0/courier'
make: *** [all-recursive] Error 1
*** Error code 2

Stop.
bmake: stopped in /v/build/pkgsrc/mail/courier-mta
*** Error code 1

Stop.
bmake: stopped in /v/build/pkgsrc/mail/courier-mta
*** Error code 1

Stop.
bmake: stopped in /v/build/pkgsrc/meta-pkgs/courier

The following packages had successfully built by then:

$ ls ~/pkg/var/db/pkg
bmake-20100423                  digest-20080510         pcre-8.02
bootstrap-mk-files-20090807nb2  f2c-20090411nb4         perl-5.10.1nb1
courier-authlib-0.63.0          libltdl-2.2.6b          pkgdb.byfile.db
courier-maildir-0.65.0          libtool-base-2.2.6bnb4  pkg_install-20100421
couriertcpd-0.65.0              maildrop-2.5.0          pkg-vulnerabilities
db4-4.8.30                      pax-20080110            tnftp-20070806

The offending line is here:

$ cat -n mail/courier-mta/work/courier-0.65.0/courier/filters/courierfilter.c | 
grep -5 377
   372  }
   373  
   374  int main(int argc, char **argv)
   375  {
   376          if (getuid() == 0)
   377                  libmail_changeuidgid(MAILUID, MAILGID);
   378                          /* Drop root privileges */
   379          if (chdir(courierdir()) < 0)
   380          {
   381                  perror("courierdir");
   382                  return (1);

and I believe the error is caused by these empty macros:

$ cat mail/courier-mta/work/courier-0.65.0/courier/uidgid.h
#define MAILUSER "candlerb"
#define MAILGROUP "candlerb"
#define MAILUID 
#define MAILGID 
$ 

although this looks OK:

$ /home/candlerb/pkg/bin/courierauthconfig --configfiles
userdb=/home/candlerb/pkg/etc/authlib/userdb
authdaemonrc=/home/candlerb/pkg/etc/authlib/authdaemonrc
authldaprc=
authmysqlrc=/home/candlerb/pkg/etc/authlib/authmysqlrc
authpgsqlrc=/home/candlerb/pkg/etc/authlib/authpgsqlrc
mailuser=candlerb
mailgroup=candlerb
mailuid=1005
mailgid=1005
sbindir=/home/candlerb/pkg/sbin
$ 

Having said all that: I've since switched from courier-imap to dovecot
anyway, so I don't really have much incentive to debug this further I'm
afraid :-(

Regards,

Brian.