Re: multimedia/vlc configuration failure

[Sverre Froyen <sverre%viewmark.com@localhost>]

> On Sun, 06 Feb 2011 22:48:00 +0900, Sverre Froyen 
> <sverre%viewmark.com@localhost> 
wrote:
> > pkgsrc libX11 does get build and installed as a prerequisite for vlc. I
> > am using native X, however, which provides its own libX11. The pkgsrc
> > libX11 includes xcb support, the native libX11 does not. I suspect that
> > the vlc configure step examines the latter.
> > 
> > The question is, how to fix this? The best solution seems to be an
> > upgrade to the native libX11.
> 
> How about following patch?
> 
> Index: multimedia/vlc/Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/multimedia/vlc/Makefile,v
> retrieving revision 1.106
> diff -u -r1.106 Makefile
> --- multimedia/vlc/Makefile     31 Jan 2011 16:47:56 -0000      1.106
> +++ multimedia/vlc/Makefile     6 Feb 2011 13:49:33 -0000
> @@ -151,6 +151,10 @@
>   .include "../../multimedia/libogg/buildlink3.mk"
>   .include "../../multimedia/libtheora/buildlink3.mk"
>   .include "../../x11/libX11/buildlink3.mk"
> +# no xcb support libX11?
> +.if ${X11_TYPE} != "modular" ||
> !exists(${X11BASE}/lib/pkgconfig/x11-xcb.pc) +CONFIGURE_ARGS+=      
> --disable-xcb
> +.endif
>   # needs x264_encoder_delayed_frames
>   BUILDLINK_API_DEPENDS.x264-devel+= x264-devel>=20100201
>   .include "../../multimedia/x264-devel/buildlink3.mk"

This works only if I *also* disable glx in options.mk. There is some magic in 
the configure script that mixes glx and xcb.

Also, the DEPENDS+= libX11 line should probably be omitted when using native 
X.

Thanks,
Sverre