Re: adding "../../graphics/MesaLib/builtin.mk" to x11/kdelibs3

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Tue, Apr 12, 2011 at 12:35:35AM +0200, Rhialto wrote:
> I notice that at some point in the past I added this to
> x11/kdelibs3/Makefile:
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/x11/kdelibs3/Makefile,v
> retrieving revision 1.152
> diff -u -r1.152 Makefile
> --- Makefile    13 Jan 2011 13:53:30 -0000      1.152
> +++ Makefile    11 Apr 2011 22:32:42 -0000
> @@ -103,6 +103,7 @@
>  .include "../../graphics/jasper/buildlink3.mk"
>  .include "../../mk/jpeg.buildlink3.mk"
>  .include "../../graphics/libart/buildlink3.mk"
> +.include "../../graphics/MesaLib/builtin.mk"
>  .include "../../graphics/openexr/buildlink3.mk"
>  .include "../../graphics/tiff/buildlink3.mk"
>  .include "../../net/mDNSResponder/buildlink3.mk"
> 
> That was probably needed for fixing the build with native X.
> 
> Can someone check if this is (still) needed and if so, commit?

Don't. Including builtin.mk files directly is almost never the right
approach and there are very, very few exceptions.

Joerg