Re: qemu package update

[Adam Hamsik <haaaad%gmail.com@localhost>]

On Jun,Sunday 5 2011, at 11:55 PM, Andy Ruhl wrote:

> On Sun, Jun 5, 2011 at 2:32 PM, Andy Ruhl <acruhl%gmail.com@localhost> wrote:
>> On Sat, Jun 4, 2011 at 5:22 PM, Adam Hamsik <haaaad%gmail.com@localhost> 
>> wrote:
>>> I have updated qemu package in my pkgsrc tree to latest available option 
>>> 0.14.1.
>>> I would like to ask for a review of my patch before I commit it.
>>> 
>>> Any thoughts ?
>> 
>> I applied the diff and tried a build and it failed:
>> 
>>  CC    host-utils.o
>>  CC    irq.o
>>  CC    ioport.o
>> ioport.c:182:60: error: macro "read" passed 4 arguments, but takes just 3
>> ioport.c: In function 'ioport_readb_thunk':
>> ioport.c:182: warning: statement with no effect
>> ioport.c:191:60: error: macro "read" passed 4 arguments, but takes just 3
>> ioport.c: In function 'ioport_readw_thunk':
>> ioport.c:191: warning: statement with no effect
>> ioport.c:200:60: error: macro "read" passed 4 arguments, but takes just 3
>> ioport.c: In function 'ioport_readl_thunk':
>> ioport.c:200: warning: statement with no effect
>> gmake: *** [ioport.o] Error 1
>> *** Error code 2
>> 
>> Stop.
>> make: stopped in /usr/pkgsrc/emulators/qemu
>> *** Error code 1
>> 
>> Stop.
>> make: stopped in /usr/pkgsrc/emulators/qemu
>> 
>> I'm going to try again shortly.
> 
> Ignore that. The patch didn't apply correctly. Unfortunately I've run
> out of time. I don't really use qemu but I wanted to start at some
> point. I'll try again when I get time.

Here is qemu dir from pkgsrc, with applied patch

http://www.netbsd.org/~haad/qemu-0.14.1.tar.bz2

Regards

Adam.