Re: Missing dep in amavisd-new (was Re: Missing dependency in p5-MIME-tools (pkgsrc-2011Q3))

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Tue, Nov 01, 2011 at 10:34:51AM +0200, Teemu Rinta-aho wrote:
> On 1.11.2011, at 0.31, Thomas Klausner wrote:
> 
> > On Mon, Oct 31, 2011 at 05:55:51PM +0200, Teemu Rinta-aho wrote:
> >> Index: Makefile
> >> ===================================================================
> >> RCS file: /cvsroot/pkgsrc/mail/p5-MIME-tools/Makefile,v
> >> retrieving revision 1.37
> >> diff -u -r1.37 Makefile
> >> --- Makefile    7 Aug 2011 08:09:01 -0000       1.37
> >> +++ Makefile    31 Oct 2011 15:55:04 -0000
> >> @@ -16,6 +16,7 @@
> >> DEPENDS+=      p5-File-Temp>=0.18:../../devel/p5-File-Temp
> >> DEPENDS+=      p5-IO-stringy-[0-9]*:../../devel/p5-IO-stringy
> >> DEPENDS+=      p5-MIME-Base64>=3.03:../../converters/p5-MIME-Base64
> >> +DEPENDS+=      p5-Convert-BinHex-[0-9]*:../../converters/p5-Convert-BinHex
> >> DEPENDS+=      p5-MailTools-[0-9]*:../../mail/p5-MailTools
> >> 
> >> PKG_INSTALLATION_TYPES=        overwrite pkgviews
> >> 
> > 
> > Why do you think it's a dependency?
> > The Makefile doesn't require it, and the tests work fine without it too.
> 
> Sorry, you are right. I was too much in a hurry. That should be added into
> mail/amavisd-new/Makefile, not in p5-MIME-tools.. I cc its maintainer here.
> 
> Without that dependency, there is an error message of Convert/BinHex.pm not 
> found
> when amavisd is started.

Actually, it seems the code that calls Convert::BinHex really is in
Mimetools. So it seems you were right.

Any dissenting opinions?
 Thomas