Re: distribution patch files

[Patrick Welche <prlw1%cam.ac.uk@localhost>]

On Tue, Oct 02, 2012 at 06:26:27PM +0100, Patrick Welche wrote:
> On Wed, Oct 03, 2012 at 01:29:22AM +0900, Ryo ONODERA wrote:
> > How about
> > 
> > PATCHFILES=             gnome-bug-224541.diff
> > PATCH_SITES=            
> > -http://bugzilla-attachments.gnome.org/attachment.cgi?id=224541

I spoke to soon, it gets me html telling me

  The attachment id 224541gnome-bug-224541.diff is invalid.

It definitely is the question mark which is causing the problem.

  ftp 'http://bugzilla-attachments.gnome.org/attachment.cgi?id=224541'

gets me the patch.

PATCH_SITES=            http://bugzilla-attachments.gnome.org/
PATCHFILES=             attachment.cgi?id=224541

Just gets

  make: don't know how to make /usr/pkgsrc/distfiles/attachment.cgi?id=224541. 
Stop

No attempt at fetching is made. Remove the ? or replace with %3F and pkgsrc
tries (and the ${...:Q} trick to quote didn't work either)


Cheers,

Patrick