Re: Firefox 24 doesn't restore session

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

Hi,

From: Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>, Date: Tue, 12 Nov 2013 
20:23:43 +0900 (JST)

> From: Martin Husemann <martin%duskware.de@localhost>, Date: Tue, 12 Nov 2013 
> 12:20:05 +0100
> 
>> On Mon, Nov 11, 2013 at 05:45:47PM +0100, Martin Husemann wrote:
>>> On Tue, Nov 12, 2013 at 01:00:59AM +0900, Izumi Tsutsui wrote:
>>> > __foo50() syscalls are introduced for 64 bit time_t changes in 6.x
>>> > and later, so NetBSD 5.x needs different symbols (__stat30() etc)?
>>> 
>>> Real fix is using nm in the build system (but I don't know how to do it).
>>> Short term fix is to query the OS version and only do the __*50 symobls
>>> on 6.0 or newer. Again, I don't know how to do that: OS.Constants.Sys
>>> seems to only have "Name" and "DEBUG" attributes.
>> 
>> Actually it is simple to distinguish in the script code:
>> 
>> Const.OSFILE_SIZEOF_TIME_T == 4 in the old case, and 8 in the new.
>> 
>> So we need something like:
>> 
>>   } else if (OS.Constants.Sys.Name == "NetBSD") {
>> 
>>      let v = Const.OSFILE_SIZEOF_TIME_T < 8 ? "30" : "50";
>> 
>>      declareLazyFFI(SysFile,  "stat", libc, "__stat"+v, ctypes.default_abi,
>>                       /*return*/ Type.negativeone_or_nothing,
>>                       /*path*/   Type.path,
>>                       /*buf*/    Type.stat.out_ptr
>>                      );
>> 
>> 
>> Ryo, do you have a testable < 6.0 environment?
> 
> Hi,
> 
> I am working on thuderbird now.
> I will try to build firefox on 5.2 virtual machine tonight with your patch
> equivalent for firefox 25.0.

Your patch equivalents that are modified for firefox 24 or 25 are
committed.

firefox 24.1.0 is not tested yet, now building.

--
Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3