Re: update sysutils/file to 5.17 (patch)

[Thomas Klausner <tk%giga.or.at@localhost>]

Hi!

On Thu, Mar 06, 2014 at 08:39:01PM +0100, 
mf+ml.pkgsrc-users%netzwerkagentursaarland.de@localhost wrote:
> please find attached a patch to update sysutils/file to version 5.17.

Thanks! I've updated the package based on your patch.

> I am unsure if buildlink3.mk also needs to be updated, it adds
> requirements for "file>=4.17", maybe that should read "file>=5.17"?

It's not necessary. For details see "14.2.2. Updating
BUILDLINK_API_DEPENDS.pkg and BUILDLINK_ABI_DEPENDS.pkg in
buildlink3.mk files" in the pkgsrc guide.

> Patch "patch-file-getline-public" re-adds the "public" keyword to the
> getline() function in getline.c that was still there with file-5.11.

I don't need this patch when building on 6.99.33/amd64, so I didn't
add this patch. What happens for you when it's not there? What
platform?

> diff -uNrwb pkgsrc/sysutils/file-5.11/patches/patch-aa 
> pkgsrc/sysutils/file/patches/patch-aa
> --- pkgsrc/sysutils/file-5.11/patches/patch-aa        2012-03-30 
> 17:25:21.000000000 +0200
> +++ pkgsrc/sysutils/file/patches/patch-aa     2014-03-06 20:25:39.000000000 
> +0100
> @@ -1,10 +1,6 @@
> -$NetBSD: patch-aa,v 1.6 2012/03/30 03:53:54 taca Exp $
> -
> -Make pkgsrc file look in @sysconfdir@/magic first.
> -

Please don't remove RCS Ids and comments from patches. Look at
pkgtools/pkgdiff for tools that help in maintaining pkgsrc patches (in
particular, mkpatches and patchdiff).

Thanks,
 Thomas