Re: [PATCH] Update PLIST.Linux for lang/mono

[Iain Morgan <Iain.Morgan%nasa.gov@localhost>]

On Fri, Jun 19, 2015 at 17:50:37 -0400, Greg Troxel wrote:
> 
> Iain Morgan <Iain.Morgan%nasa.gov@localhost> writes:
> 
> > On Thu, Jun 18, 2015 at 21:19:24 -0400, Greg Troxel wrote:
> >> 
> >> Iain Morgan <Iain.Morgan%nasa.gov@localhost> writes:
> >> 
> >> > Ah, the real issue is that the path to mscorlib.dll.so is incorrect. It
> >> > should be lib/mono/4.5/mscorlib.dll.so not lib/mono/2.0/mscorlib.dll.so.
> >> > Correcting this in PLIST.Linux fixes the issue.
> >> 
> >> Committed, thanks.  There is one more problem in the joyent pbulk logs,
> >> but what fixes it for you is an improvement for that.  (I didn't want to
> >> get into dueling changes to chase Linux inconsistencies.)
> >
> > Hi Greg,
> >
> > Is the remaining error the reference to mcs.exe.so as shown below?
> >
> > ERROR: ************************************************************
> > ERROR: The following files are in /home/pbulk/build/lang/mono/work/.destdir/usr/pkg but not in the PLIST:
> > ERROR:         /home/pbulk/build/lang/mono/work/.destdir/usr/pkg/lib/mono/4.5/mcs.exe.so
> >
> > If so, adding lib/mono/4.5/mcs.exe.so to PLIST.Linux seems to be
> > harmless. (I'm not an acutal user of mono, so I'm not prepared to say
> > how critical that file might be.) 
> 
> Are you saying that you did add it, and that it then packages?  Are you
> using PKG_DEVELOPER=yes?  (Generally, when sending in patches it is best
> to make sure that packages build with PKG_DEVELOPER=yes and pass
> pkglint.)

Yes, I added lib/mono/4.5/msc.exe.so to PLIST.Linux and it succeeded to
build the package. But no, I did not have PKG_DEVELOPER set. Thanks for
pointing that out. I can run another test with it set, and get back to
you on Monday.

-- 
Iain Morgan