Re: Please review wip/cd-hit and wip/bwa

[Jason Bacon <jwbacon%tds.net@localhost>]

Thanks for the feedback.  The cd-hit package was actually grabbing the 
wrong distfile, which complicated things.

I cleaned up both packages per your suggestions.

    JB

On 09/29/15 04:05, Thomas Klausner wrote:
> On Mon, Sep 28, 2015 at 01:30:36PM -0500, Jason Bacon wrote:
> > Both should be about ready to commit.
> cd-hit:
>
> Please take a look at mk/fetch/github.mk - I think MASTER_SITES and
> perhaps PKGNAME/DISTNAME can be simplified.
>
> SUBST_*: I think the destdir one can be replaced with MAKE_FLAGS+=
> PREFIX=${DESTDIR}${PREFIX} or similar.
>
> FETCH_USING is a user-settable variable and shouldn't be in a pkgsrc
> Makefile. Set it in /etc/mk.conf if your ftp(1) doesn't support https.
>
> Shouldn't this depend on perl if it installs perl scripts?
>
> There is no point in a bl3.mk file since this package does not provide
> libraries or headers.
>
> bwa:
>
> No bl3.mk needed.
>
>
> Cheers,
>   Thomas


--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  Jason W. Bacon
  jwbacon%tds.net@localhost

  If a problem can be solved,
  there's no need to worry.
  
  If it cannot be solved, then
  worrying will do no good.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~