Re: [PATCH] devel/talloc: Fix library install names on Darwin

["J. Lewis Muir" <jlmuir%imca-cat.org@localhost>]

On 2/18/16 8:44 AM, Greg Troxel wrote:
> "J. Lewis Muir" <jlmuir%imca-cat.org@localhost> writes:
>
>> Fix install names in all libraries on Darwin.  Previously, only the
>> talloc library was being fixed.  This allows the package to build
>> successfully with PKG_DEVELOPER=yes.
>
> I applied the patch to HEAD, with not quite the commit message (sorry,
> no good reason).  I am willing to request a pullup in a bit if you
> confirm it's ok on Darwin and nobody complains about issues elsewhere.

Thanks!

I confirm it's OK on Darwin 15.3.0 (El Capitan 10.11.3) on
pkgsrc-2015Q4.  (I copied the Makefile from HEAD into pkgsrc-2015Q4.)

> While I realize that this is arguably an upstream bug, it also seems
> that Darwin shlib issues are frequent (perhaps in most packages that
> don't use GNU libtool??).  I wonder if pkgsrc should have some sort of
> fixup infrastructure, sort of like how script paths are patched.

My feeling is that it's better to check for problems and report them
(like with PKG_DEVELOPER=yes) than to just fix them up behind the
scenes.  By reporting them, hopefully upstream can be corrected.

Of course, with infrastructure that automatically fixes things up, that
would make less work for the package maintainer.

Regards,

Lewis