Re: cwrappers ld transform problem

[Matthias Ferdinand <mf+ml.pkgsrc-users%netzwerkagentursaarland.de@localhost>]

On Wed, Mar 30, 2016 at 09:37:25AM +0200, Joerg Sonnenberger wrote:
> On Wed, Mar 30, 2016 at 12:06:40AM +0200, Matthias Ferdinand wrote:
> > cwrapper does no such transform for ld, leading to this error message:
> 
> Correct, I don't do unsolicitated expansion splitting linker options as
> they are supposed to be used independently.

Actually it is pkgsrc itself which is providing COMPILER_RPATH_FLAG to
ld:

    mk/buildlink3/bsd.buildlink3.mk:475:.        if empty(BUILDLINK_LDFLAGS:M${COMPILER_RPATH_FLAG}${_dir_})
    mk/buildlink3/bsd.buildlink3.mk:476:BUILDLINK_LDFLAGS+= ${COMPILER_RPATH_FLAG}${_dir_}
    mk/buildlink3/bsd.buildlink3.mk:492:.        if empty(BUILDLINK_LDFLAGS:M${COMPILER_RPATH_FLAG}${_dir_})
    mk/buildlink3/bsd.buildlink3.mk:493:BUILDLINK_LDFLAGS+= ${COMPILER_RPATH_FLAG}${_dir_}
    mk/buildlink3/bsd.buildlink3.mk:502:.if empty(BUILDLINK_LDFLAGS:M${COMPILER_RPATH_FLAG}${LOCALBASE}/lib)
    mk/buildlink3/bsd.buildlink3.mk:503:BUILDLINK_LDFLAGS+= ${COMPILER_RPATH_FLAG}${LOCALBASE}/lib
    mk/buildlink3/bsd.buildlink3.mk:513:.  if empty(BUILDLINK_LDFLAGS:M${COMPILER_RPATH_FLAG}${X11BASE}/lib${LIBABISUFFIX})
    mk/buildlink3/bsd.buildlink3.mk:514:BUILDLINK_LDFLAGS+= ${COMPILER_RPATH_FLAG}${X11BASE}/lib${LIBABISUFFIX}

    mk/configure/pkg-config-override.mk-25-
    mk/configure/pkg-config-override.mk-26-.if defined(_USE_RPATH) && !empty(_USE_RPATH:M[yY][eE][sS])
    mk/configure/pkg-config-override.mk-27-pkg-config-override: subst-pkgconfig
    mk/configure/pkg-config-override.mk-28-
    mk/configure/pkg-config-override.mk-29-PKGCONFIG_OVERRIDE_SED=  \
    mk/configure/pkg-config-override.mk:30: '/^Libs:.*[     ]/s|-L\([       ]*[^    ]*\)|${COMPILER_RPATH_FLAG}\1 -L\1|g'
    mk/configure/pkg-config-override.mk-31-PKGCONFIG_OVERRIDE_STAGE?=       pre-configure
    mk/configure/pkg-config-override.mk-32-

    mk/x11.buildlink3.mk:35:X11_LDFLAGS+=   ${COMPILER_RPATH_FLAG}${X11BASE}/lib${LIBABISUFFIX}

    mk/motif.buildlink3.mk:97:LDFLAGS+=             ${COMPILER_RPATH_FLAG}${_MOTIFBASE}/lib
    mk/motif.buildlink3.mk:98:MOTIFLIB?=            ${COMPILER_RPATH_FLAG}${_MOTIFBASE}/lib \

For graphics/glew, this comes in via pkg-config-override.mk.

So either this should be accepted and transformed by cwrappers, or it
should be changed in mk/... to use LINKER_RPATH_FLAG instead.


Regards
Matthias