Re: Import wip/sickbeard as multimedia/sickbeard

[Jonathan Schleifer <js-pkgsrc%webkeks.org@localhost>]

Am 12.07.2016 um 14:56 schrieb Thomas Klausner <wiz%NetBSD.org@localhost>:

> On Sat, Jul 09, 2016 at 01:49:24PM +0200, Jonathan Schleifer wrote:
>> I hereby want to propose to import wip/sickbeard as multimedia/sickbeard. Can you please review it and import it if it's fine?
> 
> The Makefile and webpage mention cherrypy and simplejson, but the
> package has no dependencies on them. Are they not needed, or included
> (cherrypy seems to be included)? Please try to make it use already
> packaged software from pkgsrc, so we only have to fix e.g. security
> problems once.

Not installing cherrypy now and deleting simplejson after extracting. It prefers the native one, but falls back to these - now it can't do that anymore. Added dependencies to Makefile.

> pkglint has some suggestions:
> WARN: Makefile:41: The user-defined variable VARBASE is used but not added to BUILD_DEFS.
> WARN: Makefile:44: The user-defined variable VARBASE is used but not added to BUILD_DEFS.
> NOTE: Makefile:54: You can use AUTO_MKDIRS=yes or "INSTALLATION_DIRS+= bin" instead of "${MKDIR}".

Installed pkglint now (WTF, this needs to build go14 and then go 1.6 just for linting Makefiles?) and fixed those.

> Is MESSAGE.SunOS still pertinent? If yes, please switch it to use
> ${PREFIX} (or @PREFIX@, don't remember right now) instead of
> /opt/local.

Since I never could test it and the SMF script (or however you call that) has been removed as a result of that, I also removed MESSAGE.SunOS, too. If someone using SunOS wants to test it and re-add those, I have no objections. But I don't feel comfortable including untested things.

> I think the INSTALL file can be replaced with OWN_DIRS_PERMS or
> REQD_DIRS_PERMS.

Changed.

--
Jonathan