Re: firefox-49.0 segfaults frequently

[David Brownlee <abs%absd.org@localhost>]

On 26 October 2016 at 14:47, <coypu%sdf.org@localhost> wrote:
>
> On Thu, Oct 20, 2016 at 08:52:43AM -0500, John D. Baker wrote:
> > [New process 133]
> > [New process 128]
>
> That's a lot of processes. I wonder if it's exceeding kern.maxfiles
> or OPEN_MAX. we have a fairly low limit of maximum open files.
>
> (I've seen this in another program that was leaking fds, so can't
> help but think about it again. fstat should tell you)
>
> Another thing that is netbsd specific, we seem to still be using gtk2
> and not gtk3.

I'm also seeing firefox-49 crash a few times per day (which is better
than firefox-47 or -48 managed, -46 was to my recollection rock
solid).

I'm recently (post firefox-49 and its issues) switched to running
current on my laptop (though with 7.0 built packages), so in terms of
data points I doubt I can contribute much going forward, but I did try
building firefox with gtk3 and so far (around ten minutes so even less
of a data point) its run fine. Some lines have more definition in the
UI, the scrollbar is prettier but marginally less useful, and the file
dialog is definitely prettier :) I think I'll be sticking with it.

Diff attached - you'll want "PKG_OPTIONS.firefox=gtk3"

I'm also running with official-mozilla-branding and JPEG_DEFAULT=libjpeg-turbo

Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/www/firefox/PLIST,v
retrieving revision 1.110
diff -u -r1.110 PLIST
--- PLIST	20 Sep 2016 20:01:41 -0000	1.110
+++ PLIST	28 Oct 2016 18:01:48 -0000
@@ -4,6 +4,8 @@
 lib/firefox/browser/blocklist.xml
 lib/firefox/browser/chrome.manifest
 ${PLIST.nobranding}lib/firefox/browser/chrome/browser/content/branding/about-background.png
+${PLIST.gtk3}lib/firefox/libmozgtk.so
+${PLIST.gtk3}lib/firefox/gtk2/libmozgtk.so
 lib/firefox/browser/chrome/browser/content/branding/about-logo.png
 lib/firefox/browser/chrome/browser/content/branding/about-logo%2x.png@localhost
 lib/firefox/browser/chrome/browser/content/branding/about-wordmark.svg
Index: mozilla-common.mk
===================================================================
RCS file: /cvsroot/pkgsrc/www/firefox/mozilla-common.mk,v
retrieving revision 1.83
diff -u -r1.83 mozilla-common.mk
--- mozilla-common.mk	20 Sep 2016 20:01:41 -0000	1.83
+++ mozilla-common.mk	28 Oct 2016 18:01:48 -0000
@@ -48,7 +48,6 @@
 CONFIGURE_ARGS+=	--enable-pie
 CONFIGURE_ARGS+=	--disable-tests
 CONFIGURE_ARGS+=	--with-pthreads
-CONFIGURE_ARGS+=	--enable-default-toolkit=cairo-gtk2
 CONFIGURE_ARGS+=	--enable-system-cairo
 CONFIGURE_ARGS+=	--enable-system-pixman
 CONFIGURE_ARGS+=	--with-system-libvpx
Index: options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/www/firefox/options.mk,v
retrieving revision 1.32
diff -u -r1.32 options.mk
--- options.mk	20 Aug 2016 11:17:32 -0000	1.32
+++ options.mk	28 Oct 2016 18:01:48 -0000
@@ -1,6 +1,11 @@
 # $NetBSD: options.mk,v 1.32 2016/08/20 11:17:32 ryoon Exp $
 
 PKG_OPTIONS_VAR=	PKG_OPTIONS.firefox
+
+PKG_OPTIONS_REQUIRED_GROUPS=	gtk
+PKG_OPTIONS_GROUP.gtk=		gtk2 gtk3
+PKG_SUGGESTED_OPTIONS=		gtk2
+
 PKG_SUPPORTED_OPTIONS=	official-mozilla-branding
 PKG_SUPPORTED_OPTIONS+=	debug debug-info mozilla-jemalloc webrtc
 PKG_SUPPORTED_OPTIONS+=	alsa oss pulseaudio dbus
@@ -17,6 +22,19 @@
 
 .include "../../mk/bsd.options.mk"
 
+PLIST_VARS+=		gtk3
+.if !empty(PKG_OPTIONS:Mgtk2)
+CONFIGURE_ARGS+=	--enable-default-toolkit=cairo-gtk2
+.include "../../x11/gtk2/buildlink3.mk"
+PLIST.gtk3=		no
+.endif
+
+.if !empty(PKG_OPTIONS:Mgtk3)
+CONFIGURE_ARGS+=	--enable-default-toolkit=cairo-gtk3
+.include "../../x11/gtk3/buildlink3.mk"
+PLIST.gtk3=		yes
+.endif
+
 .if !empty(PKG_OPTIONS:Malsa)
 CONFIGURE_ARGS+=	--enable-alsa
 .include "../../audio/alsa-lib/buildlink3.mk"