mail/neomutt install-phase error on chgrp mail mutt_dotlock

["J. Lewis Muir" <jlmuir%imca-cat.org@localhost>]

Hello!

On Darwin (macOS Sierra 10.12.1), when pbulk builds mail/neomutt from
pkgsrc-2016Q3, it fails in the install phase with the following error
from install.log (more log context is at the end of this email):

--- 8< ---
if test -f /home/pbulk/build/mail/neomutt/work/.destdir/opt/pkg/bin/mutt_dotlock && test xmail != x ; then  chgrp mail /home/pbulk/build/mail/neomutt/work/.destdir/opt/pkg/bin/mutt_dotlock &&  chmod 2755 /home/pbulk/build/mail/neomutt/work/.destdir/opt/pkg/bin/mutt_dotlock ||  { echo "Can't fix mutt_dotlock's permissions!  This is required to lock mailboxes in the mail spool directory." >&2 ; exit 1 ; }  fi
chgrp: you are not a member of group mail
Can't fix mutt_dotlock's permissions!  This is required to lock mailboxes in the mail spool directory.
*** Error code 1
--- >8 ---

So it looks like it tries to change the group of the mutt_dotlock binary
to mail, but that doesn't work because the pbulk user performing the
install-phase install to work/.destdir is not a member of the mail
group.

How can this be fixed?

The mail/mutt package does not have this problem, and I noticed that
mail/mutt/patches/patch-ab patches Makefile.in to remove the logic in
the install-exec-hook target that changes the group and mode of the
mutt_dotlock binary.

That would seem to be one possible fix, no?

Another possible fix might be to set the DOTLOCK_GROUP make variable to
the group of the pbulk user (e.g., pbulk), but I haven't tried that to
know if it would actually work.  (I'm unclear on where final ownership
and permissions come from since the install-phase install is installing
to work/.destdir with all files owned by the pbulk user (and the pbulk
user's group), but when the package built in the subsequent package
phase is installed, it will install the files with different ownership
(e.g., root:wheel).

Thanks!

Lewis

--- 8< --- (More lines of pbulk mail/neomutt install.log) ---
Making install in imap
 ./install-sh -c -d '/home/pbulk/build/mail/neomutt/work/.destdir/opt/pkg/bin'
  /usr/bin/install -c  -o pbulk -g pbulk -m 755 mutt mutt_dotlock pgpring pgpewrap '/home/pbulk/build/mail/neomutt/work/.destdir/opt/pkg/bin'
 ./install-sh -c -d '/home/pbulk/build/mail/neomutt/work/.destdir/opt/pkg/bin'
 /usr/bin/install -c -o pbulk -g pbulk -m 755 smime_keys '/home/pbulk/build/mail/neomutt/work/.destdir/opt/pkg/bin'
/opt/pkg/bin/bmake  install-exec-hook
if test -f /home/pbulk/build/mail/neomutt/work/.destdir/opt/pkg/bin/mutt.dotlock && test -f /home/pbulk/build/mail/neomutt/work/.destdir/opt/pkg/bin/mutt_dotlock ; then	 rm -f /home/pbulk/build/mail/neomutt/work/.destdir/opt/pkg/bin/mutt.dotlock ;		 ln -sf /home/pbulk/build/mail/neomutt/work/.destdir/opt/pkg/bin/mutt_dotlock /home/pbulk/build/mail/neomutt/work/.destdir/opt/pkg/bin/mutt.dotlock ;  fi
if test -f /home/pbulk/build/mail/neomutt/work/.destdir/opt/pkg/bin/mutt_dotlock && test xmail != x ; then  chgrp mail /home/pbulk/build/mail/neomutt/work/.destdir/opt/pkg/bin/mutt_dotlock &&  chmod 2755 /home/pbulk/build/mail/neomutt/work/.destdir/opt/pkg/bin/mutt_dotlock ||  { echo "Can't fix mutt_dotlock's permissions!  This is required to lock mailboxes in the mail spool directory." >&2 ; exit 1 ; }  fi
chgrp: you are not a member of group mail
Can't fix mutt_dotlock's permissions!  This is required to lock mailboxes in the mail spool directory.
*** Error code 1

Stop.
bmake[4]: stopped in /home/pbulk/build/mail/neomutt/work/neomutt-neomutt-20160916
*** Error code 1

Stop.
bmake[3]: stopped in /home/pbulk/build/mail/neomutt/work/neomutt-neomutt-20160916
*** Error code 1

Stop.
bmake[2]: stopped in /home/pbulk/build/mail/neomutt/work/neomutt-neomutt-20160916
*** Error code 1

Stop.
bmake[1]: stopped in /home/pbulk/build/mail/neomutt/work/neomutt-neomutt-20160916
*** Error code 1

Stop.
bmake: stopped in /home/pbulk/build/mail/neomutt/work/neomutt-neomutt-20160916
*** Error code 1

Stop.
bmake[1]: stopped in /opt/pkgsrc-world/pkgsrc/mail/neomutt
*** Error code 1

Stop.
bmake: stopped in /opt/pkgsrc-world/pkgsrc/mail/neomutt
--- >8 ---