Re: graphics/librsvg

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

Hi,

I propose following change to avoid segfault.
Of course, a straight fix is preferred.

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/librsvg/Makefile,v
retrieving revision 1.89
diff -u -r1.89 Makefile
--- Makefile	6 Feb 2017 13:54:45 -0000	1.89
+++ Makefile	7 Feb 2017 16:53:34 -0000
@@ -1,7 +1,7 @@
 # $NetBSD: Makefile,v 1.89 2017/02/06 13:54:45 wiz Exp $
 
 DISTNAME=	librsvg-2.40.15
-PKGREVISION=	2
+PKGREVISION=	3
 CATEGORIES=	graphics gnome
 MASTER_SITES=	${MASTER_SITE_GNOME:=sources/librsvg/${PKGVERSION_NOREV:R}/}
 EXTRACT_SUFX=	.tar.xz
@@ -20,6 +20,7 @@
 GNU_CONFIGURE=		yes
 CONFIGURE_ARGS+=	--disable-tools
 CONFIGURE_ARGS+=	--enable-Bsymbolic=auto
+CONFIGURE_ARGS+=	--disable-pixbuf-loader
 
 PKGCONFIG_OVERRIDE=	librsvg.pc.in
 
@@ -56,5 +57,5 @@
 BUILDLINK_API_DEPENDS.libcroco+=	libcroco>=0.6.1
 .include "../../textproc/libcroco/buildlink3.mk"
 .include "../../textproc/libxml2/buildlink3.mk"
-.include "../../graphics/gdk-pixbuf2/loaders.mk"
+.include "../../graphics/gdk-pixbuf2/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/librsvg/PLIST,v
retrieving revision 1.14
diff -u -r1.14 PLIST
--- PLIST	31 Jan 2017 17:06:38 -0000	1.14
+++ PLIST	7 Feb 2017 16:53:34 -0000
@@ -4,7 +4,6 @@
 include/librsvg-2.0/librsvg/librsvg-features.h
 include/librsvg-2.0/librsvg/rsvg-cairo.h
 include/librsvg-2.0/librsvg/rsvg.h
-lib/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-svg.la
 ${PLIST.introspection}lib/girepository-1.0/Rsvg-2.0.typelib
 lib/librsvg-2.la
 lib/pkgconfig/librsvg-2.0.pc


From: Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>, Date: Wed, 08 Feb 2017 01:46:09 +0900 (JST)

> Hi,
> 
> From: Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>, Date: Tue, 07 Feb 2017 21:43:16 +0900 (JST)
> 
>> Hi,
>> 
>> From: Thomas Klausner <wiz%netbsd.org@localhost>, Date: Tue, 7 Feb 2017 02:58:24 +0100
>> 
>>> On Tue, Feb 07, 2017 at 09:51:47AM +0800, Paul Goyette wrote:
>>>> With pkgsrc updated to this morning (just a couple hours ago) I am seeing
>>>> the following reproducible errors when trying to install graphics/librsvg
>>>> 
>>>> gmake[2]: Entering directory '/tmp/pkgs/graphics/librsvg/work.x86_64/librsvg-2.40.15/gdk-pixbuf-loader'
>>>>   CC       libpixbufloader_svg_la-io-svg.lo
>>>> io-svg.c: In function 'gdk_pixbuf__svg_image_load_increment':
>>>> io-svg.c:125:17: warning: 'rsvg_handle_set_size_callback' is deprecated [-Wdeprecated-declarations]
>>>>                  rsvg_handle_set_size_callback (context->handle, context->size_func, context->user_data, NULL);
>>>>                  ^
>>>> In file included from io-svg.c:28:0:
>>>> ../rsvg.h:222:6: note: declared here
>>>>  void rsvg_handle_set_size_callback (RsvgHandle * handle,
>>>>       ^
>>>>   CCLD     libpixbufloader-svg.la
>>>>   CC       rsvg_loader-test.o
>>>>   GEN      gdk-pixbuf-loaders
>>>> Makefile:807: recipe for target 'gdk-pixbuf-loaders' failed
>>>> gmake[2]: *** [gdk-pixbuf-loaders] Error 139
>>>> 
>>>> 
>>>> This is with Makefile rev 1.89 and buildlink3.mk rev 1.41
>>> 
>>> Strange, building for me on 7.99.59/amd64.
>>> 
>>> ryo reported that he saw a segfault of
>>> /usr/pkg/bin/gdk-pixbuf-query-loaders against libpixbufloader-svg.so
>>> but I didn't see that (yet?).
>> 
>> Paul's failure is as same as mine.
>> I will rebuild NetBSD/amd64 current without -u option.
> 
> Even on freshly installed VMware ESXi virtual machine with following image,
> http://nycdn.netbsd.org/pub/NetBSD-daily/HEAD/201702070350Z/images/NetBSD-7.99.59-amd64.iso
> I have gotten same segfault.
> And I have no segfault on netbsd-7/amd64.
> 
>   GEN      gdk-pixbuf-loaders
> Makefile:807: recipe for target 'gdk-pixbuf-loaders' failed
> gmake[2]: *** [gdk-pixbuf-loaders] Error 139
> gmake[2]: Leaving directory '/usr/tmp/pkgsrc/graphics/librsvg/work/librsvg-2.40.15/gdk-pixbuf-loader'
> Makefile:1367: recipe for target 'all-recursive' failed
> gmake[1]: *** [all-recursive] Error 1
> gmake[1]: Leaving directory '/usr/tmp/pkgsrc/graphics/librsvg/work/librsvg-2.40.15'
> Makefile:762: recipe for target 'all' failed
> gmake: *** [all] Error 2
> *** Error code 2
> 
> Stop.
> make[1]: stopped in /usr/pkgsrc/graphics/librsvg
> *** Error code 1
> 
> Stop.
> make: stopped in /usr/pkgsrc/graphics/librsvg
> 
>> By the way, when segfault in librsvg is ignored,
>> misc/libreoffice works with new harfbuzz and graphite2.
>>
>>>  Thomas
>> 
>> --
>> Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
>> PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3
> 
> --
> Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
> PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3