Re: mariadb55-client and libedit

[maya%netbsd.org@localhost]

On Sat, Apr 29, 2017 at 08:56:52AM +0000, Emmanuel Dreyfus wrote:
> Hello
> 
> I have trouble building mariadb55-client from pkgsrc-2017Q1 on NetBSD 7.1:
> 
> [ 88%] Building CXX object client/CMakeFiles/mysql.dir/mysql.cc.o
> /pkg_comp/obj/pkgsrc/databases/mariadb55-client/default/mariadb-5.5.52/client/mysql.cc: In function 'void initialize_readline(char*)':/pkg_comp/obj/pkgsrc/databases/mariadb55-client/default/mariadb-5.5.52/client/mysql.cc:2641:38: error: 'rl_completion_func_t' was not declared in this scope
>    rl_attempted_completion_function= (rl_completion_func_t*)&new_mysql_completion;
> 
> It is possible to get rid of it by requesting a build with readline from
> pkgsrc, but then it fail because of missing tputs symbol. I understand the
> problem is a missing -ledit, but it is not easy to add it to the build
> system.
> 
> Anyone experienced it?
> 

I see this failing in bulk builds.
Adding the following typedef to client/mysql.cc fixes the build on
netbsd 6.0 with editline:
typedef char **rl_completion_func_t(const char *, int, int);

(already fixed in -current)
But should probably not add it unconditionally.