ffmpeg3 configure fails

[Timo Buhrmester <fstd.lkml%gmail.com@localhost>]

I can't build (configure) multimedia/ffmpeg3 from pkgsrc 2017Q1
on amd64 (current).

TL;DR: (full terminal transscript below)
coconut# make configure
| => Replacing sh interpreter in configure version.sh.
| [silence for a while]
| eval: 1: Syntax error: "(" unexpected
| *** Error code 2

I tracked that down to line 587 of configure, which reads:
| eval ${pvar}_level=$(($level+1))
apparently some stack corruption happens because $(($level+1))
expands to mostly garbage ($level being a valid integer). There
seems to be deep recursion involved.  Quoting the whole expression,
i.e. turning it into
| eval "${pvar}_level=$(($level+1))"
avoids the expression expanding to garbage (but I'm still fairly
sure the stack is corrupt at that point) -- configure still fails,
but this time with a more meaningful error message (preceded by some
garbage):
| Vw3~\o: not found
| Vw3~\o: not found
| Circular dependency for h264dsp.

"Circular dependency" doesn't sound too far off, given that this
looks like a lot of recursion is happening.  However at this point
I'm not sure how to proceed.  Is anybody else seeing this? Full
terminal transcript below.


Cheers,
Timo


-------------------------------------------------------------
Below is a terminal transcript containing the following steps
| cd /usr/pkgsrc
| git log | head -n6
| uname -a
| cd /usr/pkgsrc/multimedia/ffmpeg3
| ls
| make show-options
| make configure
| # [edit configure]
| make configure

coconut# cd /usr/pkgsrc
coconut# git log | head -n6
commit 8e24a242a6ff0dfd3cfd9141d265d9885587ffa8
Author: bsiegert <bsiegert>
Date:   Mon Jun 5 09:21:37 2017 +0000

    Must ... pull ... up ... more ... stuff ...

coconut# uname -a
NetBSD coconut.pr0.tips 8.99.1 NetBSD 8.99.1 (GENADDX-9cefe9ca) #0: Wed Jun  7 12:42:45 CEST 2017  build%grapefruit.pr0.tips@localhost:/usr/obj/sys/arch/amd64/compile/GENADDX amd64
coconut# cd /usr/pkgsrc/multimedia/ffmpeg3
coconut# ls
ALTERNATIVES     DESCR            Makefile         Makefile.common  PLIST            buildlink3.mk    distinfo         options.mk       patches
coconut# make show-options
Any of the following general options may be selected:
        ass      Enable subtitle renderer for the ASS/SSA format
        doc      Include the documentation.
        ebur128 
        fdk-aac 
        fontconfig       Enable FONTCONFIG (fonts/fontconfig) support.
        freetype         Enable freetype support.
        gnutls   Enable GNU TLS support.
        lame     Use the lame encoder to create MP3 files.
        libvpx   Enable libvpx support.
        opencore-amr     Enable OpenCORE Adaptive Multi-Rate speech codecs.
        openssl  Enable OpenSSL support.
        opus     Enable opus support.
        theora   Use the theora codecs.
        vaapi    Enable support for VAAPI.
        vdpau    Enable support for VDPAU.
        vorbis   Enable Ogg Vorbis support.
        x264     Enable x264 support.
        x265     Enable x265 support.
        xcb      Enable XCB (libxcb) support.
        xvid     Enable usage of XVid codecs.

These options are enabled by default:
        ass fontconfig freetype lame libvpx openssl
        theora vaapi vdpau vorbis x264 xvid

These options are currently enabled:
        ass fontconfig freetype lame libvpx openssl
        theora vaapi vdpau vorbis x264 xvid

You can select which build options to use by setting PKG_DEFAULT_OPTIONS
or PKG_OPTIONS.ffmpeg3.
coconut# make configure
=> Bootstrap dependency digest>=20010302: found digest-20160304
===> Skipping vulnerability checks.
WARNING: No /var/db/pkg/pkg-vulnerabilities file found.
WARNING: To fix run: `/usr/sbin/pkg_admin -K /var/db/pkg fetch-pkg-vulnerabilities'.
=> Checksum SHA1 OK for ffmpeg-3.2.4.tar.bz2
=> Checksum RMD160 OK for ffmpeg-3.2.4.tar.bz2
=> Checksum SHA512 OK for ffmpeg-3.2.4.tar.bz2
===> Installing dependencies for ffmpeg3-3.2.4nb2
==========================================================================
The supported build options for ffmpeg3 are:

        ass doc ebur128 fdk-aac fontconfig freetype
        gnutls lame libvpx opencore-amr openssl opus
        theora vaapi vdpau vorbis x264 x265 xcb xvid

The currently selected options are:

        ass fontconfig freetype lame libvpx openssl
        theora vaapi vdpau vorbis x264 xvid

You can select which build options to use by setting PKG_DEFAULT_OPTIONS
or the following variable.  Its current value is shown:

        PKG_OPTIONS.ffmpeg3 (not defined)

==========================================================================
==========================================================================
The following variables will affect the build process of this package,
ffmpeg3-3.2.4nb2.  Their current value is shown below:

        * SSLBASE = /usr
        * SSLCERTS = /etc/openssl/certs
        * SSLDIR = /etc/openssl
        * SSLKEYS = /etc/openssl/private

You may want to abort the process now with CTRL-C and change their value
before continuing.  Be sure to run `/usr/bin/make clean' after
the changes.
==========================================================================
=> Tool dependency libtool-base>=2.4.2nb9: found libtool-base-2.4.6
=> Tool dependency gmake>=3.81: found gmake-4.1nb3
=> Tool dependency perl>=5.0: found perl-5.24.1nb1
=> Tool dependency pkgconf-[0-9]*: found pkgconf-1.0.1
=> Build dependency yasm>=0.7.2: found yasm-1.3.0
=> Build dependency kbproto>=1.0.2: found kbproto-1.0.7
=> Build dependency xproto>=7.0.9: found xproto-7.0.31
=> Build dependency xcb-proto>=1.4: found xcb-proto-1.12
=> Build dependency cwrappers>=20150314: found cwrappers-20170112
=> Full dependency fontconfig>=2.10.93nb2: found fontconfig-2.12.1
=> Full dependency freetype2>=2.4.11: found freetype2-2.8
=> Full dependency libass>=0.13.4nb2: found libass-0.13.4nb2
=> Full dependency libtheora>=1.0alpha3nb1: found libtheora-1.1.1nb2
=> Full dependency libvorbis>=1.1.0nb1: found libvorbis-1.3.5
=> Full dependency lame>=3.98.2nb1: found lame-3.99.5nb3
=> Full dependency xvidcore>=1.1.0nb1: found xvidcore-1.3.3
=> Full dependency x264-devel>=20111207: found x264-devel-20170122
=> Full dependency libvdpau>=0.3: found libvdpau-1.1.1nb1
=> Full dependency libva>=1.0.6: found libva-1.7.3nb5
=> Full dependency libvpx>=1.6.1: found libvpx-1.6.1
===> Overriding tools for ffmpeg3-3.2.4nb2
===> Extracting for ffmpeg3-3.2.4nb2
===> Patching for ffmpeg3-3.2.4nb2
=> Applying pkgsrc patches for ffmpeg3-3.2.4nb2
=> Fixing configuration path.
===> Creating toolchain wrappers for ffmpeg3-3.2.4nb2
===> Configuring for ffmpeg3-3.2.4nb2
mkdir /usr/pkgsrc/multimedia/ffmpeg3/work/ffmpeg-3.2.4/tmp
=> Generating pkg-config file for builtin expat package.
=> Replacing Perl interpreter in doc/texi2pod.pl.
=> Replacing sh interpreter in configure version.sh.
eval: 1: Syntax error: "(" unexpected
*** Error code 2

Stop.
make[1]: stopped in /usr/pkgsrc/multimedia/ffmpeg3
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/multimedia/ffmpeg3
coconut# #change work/ffmpeg3/configure line 587 (in function pushvar) from
coconut# # eval ${pvar}_level=$(($level+1))
coconut# # to
coconut# # eval "${pvar}_level=$(($level+1))"
coconut# make configure
=> Bootstrap dependency digest>=20010302: found digest-20160304
===> Skipping vulnerability checks.
WARNING: No /var/db/pkg/pkg-vulnerabilities file found.
WARNING: To fix run: `/usr/sbin/pkg_admin -K /var/db/pkg fetch-pkg-vulnerabilities'.
===> Configuring for ffmpeg3-3.2.4nb2
mkdir /usr/pkgsrc/multimedia/ffmpeg3/work/ffmpeg-3.2.4/tmp
=> Generating pkg-config file for builtin expat package.
=> Replacing Perl interpreter in doc/texi2pod.pl.
=> Replacing sh interpreter in configure version.sh.
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Vw3~\o: not found
Circular dependency for h264dsp.

If you think configure made a mistake, make sure you are using the latest
version from Git.  If the latest version fails, report the problem to the
ffmpeg-user%ffmpeg.org@localhost mailing list or IRC #ffmpeg on irc.freenode.net.
Include the log file "config.log" produced by configure as this will help
solve the problem.
*** Error code 1

Stop.
make[1]: stopped in /usr/pkgsrc/multimedia/ffmpeg3
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/multimedia/ffmpeg3
coconut#