Re: lang/ruby2{2,3,4}-base fail PLIST file-check on Darwin

[Min Sik Kim <minskim%NetBSD.org@localhost>]

On Jun 29, 2017, at 18:09, J. Lewis Muir <jlmuir%imca-cat.org@localhost> wrote:
> On 06/29, Min Sik Kim wrote:
>> On Jun 29, 2017, at 12:52, J. Lewis Muir <jlmuir%imca-cat.org@localhost> wrote:
>>> 
>>> Building -current from a day ago on Darwin (macOS Sierra 10.12.5) using
>>> pkg_comp (which uses pbulk), lang/ruby22-base, lang/ruby23-base, and
>>> lang/ruby24-base all fail due to a PLIST mismatch as shown below.
>>> 
>>> ========== lang/ruby22-base ==========
>>> => Checking file-check results for ruby22-base-2.2.7
>>> ERROR: ************************************************************
>>> ERROR: The following files are in the PLIST but not in /pkg_comp/work/pkg/lang/ruby22-base/work/.destdir/opt/pkg:
>>> ERROR:         /pkg_comp/work/pkg/lang/ruby22-base/work/.destdir/opt/pkg/lib/libruby22.-static.a
>>> ERROR: ************************************************************
>>> ERROR: The following files are in /pkg_comp/work/pkg/lang/ruby22-base/work/.destdir/opt/pkg but not in the PLIST:
>>> ERROR:         /pkg_comp/work/pkg/lang/ruby22-base/work/.destdir/opt/pkg/lib/libruby22.2.2.0-static.a
>>> *** Error code 1
>>> ======================================
>> 
>> Does the patch below fix it?
> 
> Hello, Min!
> 
> Yes, it does!  Thank you!
> 
> BTW, I noticed something else suspicious in lang/ruby/rubyversion.mk on
> line 538, in the PLIST_SUBST assignment:
> 
>  RUBY_SHLIBI_VERSION=${RUBY_SHLIB_VERSION:Q} RUBY_ARCH=${RUBY_ARCH:Q}
>            ^
>  Is that "I" supposed to be there?  Looks like a typo.
> 
> On top of that, is RUBY_SHLIB_VERSION set to anything?  Obviously it
> wasn't for Darwin in light of this build issue and your patch, and I
> can't find a reference to it anywhere.  So, maybe this line should just
> go away entirely?

I think both RUBY_SHLIBI_VERSION and RUBY_SHLIB_VERSION should be
RUBY_SHLIBVER, because the same file also has the following:

PRINT_PLIST_AWK+=	/${RUBY_SLEXT}\.${RUBY_SHLIBVER}$$/ \
			{ sub(/${RUBY_SLEXT}\.${RUBY_SHLIBVER}$$/, \
			"$${RUBY_SLEXT}.$${RUBY_SHLIBVER}"); }

taca@, could you confirm this?


Regards,
Min