Re: time/ical build failure

[Paul Goyette <paul%whooppee.com@localhost>]

On Sun, 18 Feb 2018, Havard Eidnes wrote:

> > <error messages snipped>
>
> Fixed these ones by using the suggested newer API.

Yes, thanks, those errors are gone.

> > ...
> >
> > In file included from main.C:27:0:
> > bitmaps/left.xbm:7:50: error: narrowing conversion of '128' from 'int'
> > to 'char' inside { } [-Wnarrowing]
> >     0x20, 0x01, 0x40, 0x01, 0x80, 0x01, 0x00, 0x00};
> >                                                   ^
> > bitmaps/left.xbm:7:50: error: narrowing conversion of '128' from 'int'
> > to 'char' inside { } [-Wnarrowing]
> > In file included from main.C:28:0:
> > bitmaps/right.xbm:7:50: error: narrowing conversion of '128' from
> > 'int' to 'char' inside { } [-Wnarrowing]
> >     0x80, 0x04, 0x80, 0x02, 0x80, 0x01, 0x00, 0x00};
> >                                                   ^
> > bitmaps/right.xbm:7:50: error: narrowing conversion of '128' from
> > 'int' to 'char' inside { } [-Wnarrowing]
> > bitmaps/right.xbm:7:50: error: narrowing conversion of '128' from
> > 'int' to 'char' inside { } [-Wnarrowing]
> >
> > <lots more of these!>
>
> Hmm, using 8.0_BETA I don't get these warnings, perhaps it's
> caused by new checks in the new compiler; 8.0_BETA has gcc 5.5.0.
>
> And, well, I suspect the correct fix is more widspread use of
> "unsigned char", since, indeed 0x80 == 128 isn't part of the
> value range for signed char.  However, that's likely to cause
> cascading type changes...  Is the packge being built with -Werror?

This is almost certainly due to the update of gcc-6 on amd64-HEAD

This is a totally-default build, on an amd64 host running 8.99.12 from 
just a few days ago.  And there are no error messages other than the 
-Wnarrowing errors.  (But there are dozens of these messages, and they 
are reported in several *.xbm files, not only {left,right}.xbm!)

> Regards,
>
> - Håvard
>
> !DSPAM:5a89df73108481964718772!

+------------------+--------------------------+----------------------------+
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
+------------------+--------------------------+----------------------------+