Re: digest pkglint-compliant

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Fri, Mar 23, 2018 at 08:27:48AM +0100, Frédéric Fauberteau wrote:
> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/pkgtools/digest/Makefile,v
> retrieving revision 1.61
> diff -u -r1.61 Makefile
> --- Makefile	9 Oct 2014 14:06:49 -0000	1.61
> +++ Makefile	23 Mar 2018 07:21:32 -0000
> @@ -21,14 +21,14 @@
>  		${FILESDIR}/configure
> 
>  do-extract:
> -	@${CP} -R ${FILESDIR} ${WRKSRC}
> +	${RUN} ${CP} -R ${FILESDIR} ${WRKSRC}

This part is fine.

>  pre-install:
> -	-@${MKDIR} ${DESTDIR}${PKG_DBDIR}
> +	${RUN} ${MKDIR} ${DESTDIR}${PKG_DBDIR} || ${TRUE}

I don't see why this whole rule exist in first place, I think it should
be removed?

>  do-test:
> -	@${ECHO} "No news is good news"
> -	@cd ${WRKSRC} && ${SETENV} DIGESTDIR=${WRKSRC} ${SH} ./regress.sh
> -	@${ECHO} "All tests completed"
> +	${RUN} ${ECHO} "No news is good news"
> +	${RUN} cd ${WRKSRC} && ${SETENV} DIGESTDIR=${WRKSRC} ${SH} ./regress.sh
> +	${RUN} ${ECHO} "All tests completed"

Fine.

> Index: distinfo
> ===================================================================
> RCS file: distinfo
> diff -N distinfo
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ distinfo	23 Mar 2018 07:21:32 -0000
> @@ -0,0 +1 @@
> +$NetBSD$

Not fine. No distinfo should be added.

Joerg