Problem installing security/heimdal on Ubuntu 18.04 (WSL)

["David J. Weller-Fahy" <l.pkgsrc-users%dave.caterva.org@localhost>]

Greetings,

I'm attempting to install security/heimdal on Ubuntu 18.04 that is installed on Windows 10 WSL (Windows Subsystem for Linux). I've figured out how to change the Makefile (v1.127) to make it install properly, but have been unable to have the proper variable be set conditionally.

First, if I try a `bmake install clean clean-depends` without fixing the Makefile at all, then I get the following error which terminates the installation process:

#v+
...
=> Automatic manual page handling
=> Generating post-install file lists
=> Checking file-check results for heimdal-1.5.3nb18
ERROR: ************************************************************
ERROR: The following files are in /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg but not in the PLIST:
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/aes.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/bn.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/des.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/dh.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/dsa.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/ec.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/ecdh.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/ecdsa.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/engine.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/evp-cc.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/evp-hcrypto.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/evp.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/hmac.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/md2.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/md4.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/md5.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/pkcs12.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/rand.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/rc2.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/rc4.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/rsa.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/sha.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/include/krb5/hcrypto/ui.h
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/lib/libhcrypto.a
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/lib/libhcrypto.la
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/lib/libhcrypto.so
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/lib/libhcrypto.so.4
ERROR:         /home/dave/pkg/usr/work/security/heimdal/work/.destdir/home/dave/pkg/lib/libhcrypto.so.4.1.0
*** Error code 1

Stop.
bmake[1]: stopped in /home/dave/usr/src/pkgsrc/security/heimdal
*** Error code 1

Stop.
bmake: stopped in /home/dave/usr/src/pkgsrc/security/heimdal
#v-

That led me to set `PLIST.hcrypto=yes` in the Makefile, which allowed security/heimdal to install properly.

It seems, however, that this problem does not occur on normal Linux installations, therefore there is a need to detect that a Linux installation is WSL hosted. The only reliable way I have discovered to detect WSL is to use the full output of `uname -r`, which on my installation is "4.4.0-17134-Microsoft", and check for the string "Microsoft". To that end I put the following in the Makefile.

#v+
_OSV_CMD=${UNAME} -r
OSV=${_OSV_CMD:sh}
.if ${OPSYS} == "Linux" && !empty(OSV:MMicrosoft)
PLIST.hcrypto=yes
.endif
#v-

However, that results in the failure I experience with the unmodified Makefile. Does anyone know how to properly check for the "Microsoft" string in the output of `uname -r` so that I can set the PLIST.hcrypto only on WSL installations? If so, please let me know, because I'd like to submit an update to the package once I figure it out.

Regards,
  -dave