pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Bug in mk/plist/plist-info.awk



Hi.

I found a bug in mk/plist/plist-info.awk, which I am hesitating to fix myself because I don't fully understand why the following reg-ex is written like it is.

It's the line 103:

    /^([^\/]*\/)*(info\/[^\/]+(\.info)?|[^\/]+\.info)$/ {

Because of this ? after (\.info) some unrelated lines like this one:

lib/python3.6/site-packages/conans/test/unittests/model/info/__init__.py

get (incorrectly) matched which results in them being skipped, while
when PLIST is processed by lang/python/plist-python.awk later.

I am not 100% if this ? was added by mistake, but it results in files like
one mentioned above being matched.

Not sure I understand why the cases

    path/to/some/info/file.info

and

    path/to/some/file.info

are matched separately.

So to me, the whole reg-ex should be written as:

    /^([^\/]*\/)*[^\/]+\.info$/

But I might miss something.


--
Aleksej Lebedev


Home | Main Index | Thread Index | Old Index