Inkscape crash glibmm wchar conversion

[clément bouvier <clement.bouvier.europe%gmail.com@localhost>]

Hi,

Graphics/inkscape crashes very early on darwin macos (10.14.4 mojave) with the following report:

libc++abi.dylib: terminating with uncaught exception of type Glib::ConvertError

This kind of bug was already reported by a macports developer to upstream with patch (Gnome/glibmm) with the version 2.56.0

https://bugzilla.gnome.org/show_bug.cgi?id=795338

This is the version currently in pkgsrc.

A minor release was released 2.56.1 with the patch (NEWS):

2.56.1 (stable):

Glib:
* ustring: Fix wchar conversion on macOS with libc++
  (Clemens Lang) Bug #795338

I upgraded the pkgsrc package to the version 2.56.1 and  modified a previous patch by adam@ about the string conversion on netbsd.

I checked macos 10.14.4 and amd64 netbsd 8. Inkscape is running with glibmm change.

Hereunder the diff of the modified package (devel/glibmm).
The change is a minor release upgrade.

Is is also better to fill a PR? Probably there is errors too (first time you know…)

Regards,
Clément.

  Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/glibmm/Makefile,v
retrieving revision 1.78
diff -r1.78 Makefile
3,4c3,4
< DISTNAME=     glibmm-2.56.0
< PKGREVISION=  1
---
> DISTNAME=     glibmm-2.56.1
> 
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/devel/glibmm/distinfo,v
retrieving revision 1.54
diff -r1.54 distinfo
3,6c3,6
< SHA1 (glibmm-2.56.0.tar.xz) = d733d9206d706d53058749f92dfb319bb189c289
< RMD160 (glibmm-2.56.0.tar.xz) = 83d0d3fe5c468883449bc082f5561d99329f1c4f
< SHA512 (glibmm-2.56.0.tar.xz) = 65e577009019e30e340ae5fe6e4c854e5a75551b2eb83ad85403d73eb4e77879783162d4c3c354bc37be0be842f0ddffc1977021a5e0c32985fb596d86929c08
< Size (glibmm-2.56.0.tar.xz) = 6859520 bytes
---
> SHA1 (glibmm-2.56.1.tar.xz) = 992c7510e489a98475fcf40e50415d6ba48402de
> RMD160 (glibmm-2.56.1.tar.xz) = d0424eea980619901ded384b1b9f70f66e481ad0
> SHA512 (glibmm-2.56.1.tar.xz) = fd5ad19c5dcba484573520e1d00b5bbb600ee805ab8cd9c0d985880cc1bcbe67ad31fa9f2b5789b5892eddd6be345e3f308593e5ef021e1cfda132e4235fb735
> Size (glibmm-2.56.1.tar.xz) = 6841240 bytes
8c8
< SHA1 (patch-glib_glibmm_ustring.cc) = b4fc8965bc5fc1bcc5ea1ac377a13b22659557ee
---
> SHA1 (patch-glib_glibmm_ustring.cc) = ec24a0549e71153625c171374699332637831991
Index: patches/patch-glib_glibmm_ustring.cc
===================================================================
RCS file: /cvsroot/pkgsrc/devel/glibmm/patches/patch-glib_glibmm_ustring.cc,v
retrieving revision 1.2
diff -r1.2 patch-glib_glibmm_ustring.cc
1c1
< $NetBSD: patch-glib_glibmm_ustring.cc,v 1.2 2016/04/12 21:27:25 adam Exp $
---
> $NetBSD$
5c5
< --- glib/glibmm/ustring.cc.orig       2016-02-29 09:31:32.000000000 +0000
---
> --- glib/glibmm/ustring.cc.orig       2018-05-06 10:47:56.000000000 +0000
7c7
< @@ -1353,7 +1353,7 @@ ustring::FormatStream::to_string() const
---
> @@ -1364,7 +1364,7 @@ ustring::FormatStream::to_string() const
11,12c11,12
< -#if defined(__STDC_ISO_10646__) && SIZEOF_WCHAR_T == 4
< +#if (defined(__STDC_ISO_10646__) || defined(__NetBSD__)) && SIZEOF_WCHAR_T == 4
---
> -#if (defined(__STDC_ISO_10646__) || defined(_LIBCPP_VERSION)) && SIZEOF_WCHAR_T == 4
> +#if (defined(__STDC_ISO_10646__) || defined(_LIBCPP_VERSION) || defined(__NetBSD__)) && SIZEOF_WCHAR_T == 4
16c16
< @@ -1441,7 +1441,7 @@ operator>>(std::wistream& is, ustring& u
---
> @@ -1452,7 +1452,7 @@ operator>>(std::wistream& is, ustring& u
20,21c20,21
< -#if defined(__STDC_ISO_10646__) && SIZEOF_WCHAR_T == 4
< +#if (defined(__STDC_ISO_10646__) || defined(__NetBSD__)) && SIZEOF_WCHAR_T == 4
---
> -#if (defined(__STDC_ISO_10646__) || defined(_LIBCPP_VERSION)) && SIZEOF_WCHAR_T == 4
> +#if (defined(__STDC_ISO_10646__) || defined(_LIBCPP_VERSION) || defined(__NetBSD__)) && SIZEOF_WCHAR_T == 4
25c25
< @@ -1472,7 +1472,7 @@ operator<<(std::wostream& os, const ustr
---
> @@ -1483,7 +1483,7 @@ operator<<(std::wostream& os, const ustr
29,30c29,30
< -#if defined(__STDC_ISO_10646__) && SIZEOF_WCHAR_T == 4
< +#if (defined(__STDC_ISO_10646__) || defined(__NetBSD__)) && SIZEOF_WCHAR_T == 4
---
> -#if (defined(__STDC_ISO_10646__) || defined(_LIBCPP_VERSION)) && SIZEOF_WCHAR_T == 4
> +#if (defined(__STDC_ISO_10646__) || defined(_LIBCPP_VERSION) || defined(__NetBSD__)) && SIZEOF_WCHAR_T == 4