Re: "graphics/xfig" complains about old/missing app-defaults?

[Thomas Klausner <tk%giga.or.at@localhost>]

Thank you, I've committed this patch.
 Thomas

On Thu, Jun 20, 2019 at 01:29:43AM -0500, John D. Baker wrote:
> On Thu, 20 Jun 2019, John D. Baker wrote:
> 
> > On Thu, 20 Jun 2019, Robert Elz wrote:
> > 
> > >   | Also, the "xfig" package installs the "Fig" resource file to
> > >   |
> > >   |   /usr/pkg/share/X11/app-defaults
> > >   |
> > >   | while packages like "tightvncviewer", "xlock" and "xscreensaver" store
> > >   | their resource files to "/usr/pkg/lib/X11/app-defaults".  Perhaps there
> > >   | is a consistency issue here?
> > > 
> > > Yes, that one might indicate a bug that ought to be fixed.
> 
> The following patches make "graphics/xfig"  use the same app-defaults
> directory as other pkgsrc Xresource-using packages:
> 
> +Index: graphics/xfig/Makefile
> +===================================================================
> +RCS file: /cvsroot/pkgsrc/graphics/xfig/Makefile,v
> +retrieving revision 1.72
> +diff -u -p -r1.72 Makefile
> +--- graphics/xfig/Makefile      3 Oct 2017 15:09:36 -0000       1.72
> ++++ graphics/xfig/Makefile      20 Jun 2019 06:17:23 -0000
> +@@ -16,6 +16,8 @@ XAW_TYPE?=            3d
> + 
> + GNU_CONFIGURE=         yes
> + 
> ++CONFIGURE_ARGS+=       --with-appdefaultdir=${PREFIX}/lib/X11/app-defaults
> ++
> + .include "../../mk/jpeg.buildlink3.mk"
> + .include "../../graphics/png/buildlink3.mk"
> + .include "../../x11/libXi/buildlink3.mk"
> +ndex: graphics/xfig/PLIST
> +===================================================================
> +RCS file: /cvsroot/pkgsrc/graphics/xfig/PLIST,v
> +retrieving revision 1.12
> +diff -u -p -r1.12 PLIST
> +--- graphics/xfig/PLIST 3 Oct 2017 15:09:36 -0000       1.12
> ++++ graphics/xfig/PLIST 20 Jun 2019 06:21:59 -0000
> +@@ -1,7 +1,7 @@
> + @comment $NetBSD: PLIST,v 1.12 2017/10/03 15:09:36 wiz Exp $
> + bin/xfig
> + man/man1/xfig.1
> +-share/X11/app-defaults/Fig
> ++lib/X11/app-defaults/Fig
> + share/applications/xfig.desktop
> + share/doc/xfig/FORMAT1.3
> + share/doc/xfig/FORMAT1.4
> 
> 
> Still no dice at it being quiet, so it's most likely that this is the
> first time I used 'xfig' without "XAPPLRESDIR" being set in "/etc/profile".
> 
> It's also likely that prior to 3 Oct 2017, "xfig" normally used
> "/usr/pkg/lib/X11/app-defaults", but the package history seems to
> be lost.
> 
> 
> -- 
> |/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
> |\ / jdbaker[snail]consolidated[flyspeck]net  OpenBSD            FreeBSD
> | X  No HTML/proprietary data in email.   BSD just sits there and works!
> |/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645
>