pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: minidlna buffer overflow on netbsd-8/amd64



On Sat, Oct 26, 2019 at 07:18:39PM -0500, John D. Baker wrote:
> On Sat, 26 Oct 2019, maya%NetBSD.org@localhost wrote:
> 
> > As a starting point, it uses MAXPATHLEN as a buffer size. I think it
> > should be MAXPATHLEN+1 (or PATH_MAX) to avoid an overflow with the null
> > byte.
> > (Highly unlikely this could be abused).
> 
> So, I did global search and destroy^Wreplace of MAXPATHLEN with PATH_MAX
> and the resulting binary behaves the same.  Still gets overflow and
> terminated.
> 

Sorry. I asked again about that and apparently the confusion is mine.


Home | Main Index | Thread Index | Old Index