pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Set install_name to fix devel/mustach on macOS



Sijmen Mulder <ik%sjmulder.nl@localhost> writes:

> devel/mustach builds are failing on macOS because no install_name is
> set. Attached patch should fix it (and does so on my machine) but
> I'd appreciate someone with macOS experience taking a look.
>
> Build failure:
>  https://us-east.manta.joyent.com/pkgsrc/public/reports/Darwin/10.14/trunk/x86_64/20191220.0920/mustach-0.99/install.log
>
> Upstream PR:
>  https://gitlab.com/jobol/mustach/merge_requests/16
>
> ok?

I am having trouble following.  The diff upstream and this diff don't
look the same.

Also, it seems like upstream does not require gmake, and the patch
introduces a gmake dependency.  It would seem our usual approach (beyond
an upstream-ok patch) would be  to SUBST something like
@installnameflags@ to either what macos needs or empty, depending on OS
in our Makefile.



Home | Main Index | Thread Index | Old Index