Re: devel/binutils broken on CentOS 7

[Jason Bacon <outpaddling%yahoo.com@localhost>]

On 2020-02-28 14:18, Ottavio Caruso wrote:
> On Fri, 28 Feb 2020 at 14:55, Jason Bacon <outpaddling%yahoo.com@localhost> wrote:
> > On 2020-02-17 19:21, Jason Bacon wrote:
> > > Anyone else having trouble with this?
> > >
> > > This is an odd problem in that the library is being built
> > > successfully, just not installed.
> > >
> > > Any suggestions would be appreciated.
> > >
> > > Thanks...
> > >
> > > => Automatic manual page handling
> > > => Generating post-install file lists
> > > => Checking file-check results for binutils-2.34
> > > ERROR: ************************************************************
> > > ERROR: The following files are in the PLIST but not in
> > > /home/bacon/Pkgsrc/pkgsrc/devel/binutils/work/.destdir/home/bacon/Pkgsrc/pkg:
> > > ERROR:
> > > /home/bacon/Pkgsrc/pkgsrc/devel/binutils/work/.destdir/home/bacon/Pkgsrc/pkg/include/ctf-api.h
> > > ERROR:
> > > /home/bacon/Pkgsrc/pkgsrc/devel/binutils/work/.destdir/home/bacon/Pkgsrc/pkg/include/ctf.h
> > > ERROR:
> > > /home/bacon/Pkgsrc/pkgsrc/devel/binutils/work/.destdir/home/bacon/Pkgsrc/pkg/lib/libctf.la
> > > ERROR:
> > > /home/bacon/Pkgsrc/pkgsrc/devel/binutils/work/.destdir/home/bacon/Pkgsrc/pkg/lib/libctf-nobfd.la
> > > *** Error code 1
> > >
> > > Stop.
> > > bmake.bin[1]: stopped in /home/bacon/Pkgsrc/pkgsrc/devel/binutils
> > > *** Error code 1
> > >
> > > Stop.
> > > bmake.bin: stopped in /home/bacon/Pkgsrc/pkgsrc/devel/binutils
> > > Linux ramora.uits  bacon ~/Pkgsrc/pkgsrc/devel/binutils 277: find .
> > > -name 'libctf*'
> > > ./work/binutils-2.34/libctf
> > > ./work/binutils-2.34/libctf/libctf.ver
> > > ./work/binutils-2.34/libctf/.libs/libctf.a
> > > ./work/binutils-2.34/libctf/.libs/libctf.la
> > > ./work/binutils-2.34/libctf/.libs/libctf-nobfd.a
> > > ./work/binutils-2.34/libctf/.libs/libctf-nobfd.la
> > > ./work/binutils-2.34/libctf/libctf.la
> > > ./work/binutils-2.34/libctf/libctf-nobfd.la
> I can replicate the error above on Debian stretch and the patch works
> fine here.
Thanks for the feedback.

Given that stretch is a current distro, it seems we should disable CTF 
for all Linux distros for now.  Below is a patch using a PLIST var as 
jperkin suggested.

It's probably broken on some other platforms well, but we easily add 
them as they're discovered.

Any other concerns or suggestions?

    JB

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/binutils/Makefile,v
retrieving revision 1.79
diff -u -r1.79 Makefile
--- Makefile    5 Feb 2020 06:18:34 -0000    1.79
+++ Makefile    29 Feb 2020 00:54:14 -0000
@@ -50,7 +50,7 @@

 # gprof (XXX: and others?) cannot be built on all platforms
 #
-PLIST_VARS+=    gprof ld gold SunOS
+PLIST_VARS+=    gprof ld gold SunOS CTF

 .include "../../mk/bsd.prefs.mk"

@@ -66,6 +66,10 @@
 PLIST.SunOS=    yes
 .endif

+.if ${OPSYS} != Linux
+PLIST.CTF=    yes
+.endif
+
 .if ${OPSYS} == DragonFly \
     || (${OPSYS} == FreeBSD && empty(OS_VERSION:M[12345678].*)) \
     || (${OPSYS} == OpenBSD && empty(OS_VERSION:M[1234].*)) \
Index: PLIST.common
===================================================================
RCS file: /cvsroot/pkgsrc/devel/binutils/PLIST.common,v
retrieving revision 1.29
diff -u -r1.29 PLIST.common
--- PLIST.common    5 Feb 2020 06:18:34 -0000    1.29
+++ PLIST.common    29 Feb 2020 00:54:14 -0000
@@ -68,8 +68,8 @@
 include/bfd.h
 include/bfd_stdint.h
 include/bfdlink.h
-include/ctf-api.h
-include/ctf.h
+${PLIST.CTF}include/ctf-api.h
+${PLIST.CTF}include/ctf.h
 include/diagnostics.h
 include/dis-asm.h
 include/plugin-api.h
@@ -80,8 +80,8 @@
 ${PLIST.gprof}info/gprof.info
 info/ld.info
 lib/libbfd.la
-lib/libctf-nobfd.la
-lib/libctf.la
+${PLIST.CTF}lib/libctf-nobfd.la
+${PLIST.CTF}lib/libctf.la
 lib/libopcodes.la
 man/man1/gaddr2line.1
 man/man1/gar.1