Re: go114 patch

[Chavdar Ivanov <ci4ic4%gmail.com@localhost>]

On Mon, 6 Apr 2020 at 18:40, Benny Siegert <bsiegert%gmail.com@localhost> wrote:
>
> This has nothing to do with upstream. If you look closely, this
> downgrades the distfile from 1.14.1 to 1.14 (.0).

That is absolutely true. I've updated lang/go114, but missed updating
lang/go, newbies' mistake. I usually upfate everything and run
pkg_rolling-replace, but as I didn't have go114 installed at all I
just went and did the update incorrectly.

So forget it.

>
> You will need to update lang/go/version.mk as well.
>
> On Mon, Apr 6, 2020 at 7:30 PM Dr. Thomas Orgis
> <thomas.orgis%uni-hamburg.de@localhost> wrote:
> >
> > Am Mon, 6 Apr 2020 18:04:35 +0100
> > schrieb Chavdar Ivanov <ci4ic4%gmail.com@localhost>:
> >
> > > Hi,
> > >
> > > go114 source seems to have changed since addition; the attached patch
> > > builds it again; only a few of the tests fail.
> >
> > Thanks for noticing this. But the changes are strange, especially such:
> >
> > -go114/test/fixedbugs/issue37716.go
> >
> > There is a test vanishing? Besides, changing tarballs without changing
> > version is just not good. Did you complain to upstream about this mess?
> >
> > Do you have an old version of the tarball handy and can show a full
> > diff of old vs. new? If not … you can grab one from
> >
> >         http://src.rrz.uni-hamburg.de/go1.14.1.src.tar.gz
> > .
> > This one's the old one and will stay that way without manual
> > intervention since the mirror is not configured to roam about and check
> > if distributed source tarballs change. It's a nice example of upstream
> > breaking infrastructure. It's tiny minority of projects that change
> > release tarballs after the fact (well, not considering those that don't
> > do any release tarballs at all), and we shouldn't let that bad
> > behaviour just pass. This is a bug for upstream to at least do a proper
> > re-release with incremented bugfix version.
> >
> >
> > Regards,
> >
> > Thomas
> >
> > --
> > Dr. Thomas Orgis
> > HPC @ Universität Hamburg
>
>
>
> --
> Benny



-- 
----